A new robotic pet can be spawned. #475
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From Volkan's workshop, meet his new companion! It can fetch, fly around and in general be a good pet. Still under construction.
…le to buckle to humans, even if forced = TRUE. Also, things in the typecache with forced = FALSE will work now.
…an imprint key inside.
Moved the pet AI code to their own files.
MrMelbert
reviewed
Apr 28, 2024
MrMelbert
reviewed
Apr 28, 2024
maplestation_modules/story_content/volkan_equipment/code/volkanitems.dm
Outdated
Show resolved
Hide resolved
MrMelbert
reviewed
Apr 28, 2024
maplestation_modules/story_content/volkan_equipment/code/volkanpets.dm
Outdated
Show resolved
Hide resolved
MrMelbert
reviewed
Apr 28, 2024
maplestation_modules/story_content/volkan_equipment/code/volkanpets_ai.dm
Outdated
Show resolved
Hide resolved
…npets_ai.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
|
Right, this is as good as I can get it without figuring out how to add ultra super complex AI features. It is a fully functional pet! It just cannot fix wires for me :) |
|
Do I put //NON MODULE CHANGE |
|
Yeah, I think I'll move the perch command into modules, and leave the bugfix and add //non module change to it. |
|
done done!! |
|
I don't think my PR caused those test fails |
MrMelbert
reviewed
Jun 20, 2024
There was a problem hiding this comment.
Rename this file to attribution.txt, it's a bit more uniform
MrMelbert
reviewed
Jun 20, 2024
maplestation_modules/story_content/volkan_equipment/code/volkanitems.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/story_content/volkan_equipment/code/volkanpets.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/story_content/volkan_equipment/code/volkanpets_ai.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/story_content/volkan_equipment/code/volkanpets_ai.dm
Outdated
Show resolved
Hide resolved
maplestation_modules/story_content/volkan_equipment/code/volkanitems.dm
Outdated
Show resolved
Hide resolved
…nitems.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
…npets.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
…npets_ai.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
…nitems.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
…npets_ai.dm Co-authored-by: MrMelbert <51863163+MrMelbert@users.noreply.github.com>
to resolve code review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this?
From Volkan's workshop, meet his new companion!
It can fetch, fly around and in general be a good pet.
Also, when imprinted with a special custom key, it can perch on your shoulder with a command, and do other commands such as fetch!
It is not designed for combat. It is probably very bad at it.
Also included is a big unfoldable box to hold all the Volkan items.