Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

Clear GeckoSession histroy when clearing history. Fixes #1749 #1903

Merged
merged 1 commit into from
Oct 3, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,12 @@ public void setCurrentSession(int aId) {
}
}

public void purgeHistory() {
for (Map.Entry<Integer, SessionState> entry :mSessions.entrySet()) {
entry.getValue().mSession.purgeHistory();
}
}

public void setRegion(String aRegion) {
Log.d(LOGTAG, "SessionStack setRegion: " + aRegion);
mRegion = aRegion != null ? aRegion.toLowerCase() : "worldwide";
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ public HistoryStore getHistoryStore() {
return mHistoryStore;
}

public void purgeSessionHistory() {
for (Map.Entry<Integer, SessionStack> entry : mSessionStacks.entrySet()) {
entry.getValue().purgeHistory();
}
}

public void onPause() {
for (Map.Entry<Integer, SessionStack> entry : mSessionStacks.entrySet()) {
entry.getValue().setActive(false);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ default void onBookmarksHidden(WindowWidget aWindow) {}
private WidgetPlacement mPlacementBeforeResize;
private boolean mIsResizing;
private boolean mIsFullScreen;
private boolean mAfterFirstlPaint;
private boolean mAfterFirstPaint;

public interface WindowDelegate {
void onFocusRequest(@NonNull WindowWidget aWindow);
Expand Down Expand Up @@ -1138,15 +1138,16 @@ public void showClearCacheDialog() {
store.deleteVisitsBetween(todayLimit, currentTime);
break;
case ClearCacheDialogWidget.YESTERDAY:
store.deleteVisitsBetween(yesterdayLimit, todayLimit);
store.deleteVisitsBetween(yesterdayLimit, currentTime);
break;
case ClearCacheDialogWidget.LAST_WEEK:
store.deleteVisitsBetween(oneWeekLimit, yesterdayLimit);
store.deleteVisitsBetween(oneWeekLimit, currentTime);
break;
case ClearCacheDialogWidget.EVERYTHING:
store.deleteEverything();
break;
}
SessionStore.get().purgeSessionHistory();
}
});
mClearCacheDialog.show(REQUEST_FOCUS);
Expand Down Expand Up @@ -1436,7 +1437,7 @@ public void onContextMenu(GeckoSession session, int screenX, int screenY, Contex

@Override
public void onFirstComposite(@NonNull GeckoSession session) {
if (!mAfterFirstlPaint) {
if (!mAfterFirstPaint) {
return;
}
if (mFirstDrawCallback != null) {
Expand All @@ -1447,13 +1448,13 @@ public void onFirstComposite(@NonNull GeckoSession session) {

@Override
public void onFirstContentfulPaint(@NonNull GeckoSession session) {
if (mAfterFirstlPaint) {
if (mAfterFirstPaint) {
return;
}
if (mFirstDrawCallback != null) {
ThreadUtils.postToUiThread(mFirstDrawCallback);
mFirstDrawCallback = null;
mAfterFirstlPaint = true;
mAfterFirstPaint = true;
}
}

Expand Down