This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Clear GV history after wiping of the history #1874
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should wait until GV support the session history clear. Having the windows disappear when clearing history is jaring. I think having the forward/back buttons still work is the lesser of the two issues. Maybe break out the fix for what history gets cleared to a different PR? |
bluemarvin
suggested changes
Sep 25, 2019
|
|
918a522 to
ae782b4
Compare
|
@keianhzo The GeckoSession.purgeHistory() function is now available in GeckoView. |
|
This is now addressed in #1903 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1749 Clear navigation buttons after history is cleared by recreating the session. Also fixed the way history is cleared, before we could clear yesterday and last week's entries but seeing the way desktop does it it makes more sense to always clean from now to those ranges.