Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

[Add-ons][Privacy Badger] The Library is dismissed after removing the add-on while the Thank You page is displayed in the background #3812

Closed
Softvision-RemusDranca opened this issue Aug 14, 2020 · 1 comment · Fixed by #3821
Closed

[Add-ons][Privacy Badger] The Library is dismissed after removing the add-on while the Thank You page is displayed in the background #3812

Softvision-RemusDranca opened this issue Aug 14, 2020 · 1 comment · Fixed by #3821
Assignees
@keianhzo
Labels
[QA]:Caught_by_exploratory Bugs found during exploratory testing [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues

Comments

@Softvision-RemusDranca
Copy link

[Notes]:

  • As a side effect of this issue when reopening the Library the Manage page of the add-on is displayed, even if it was removed, and the "Back" arrow button is not displayed, making the navigation to the Add-ons main page hard to performed.

[Affected Versions]:

  • Firefox Reality version 12 RC1 (cc3eab0)

[Affected Platforms]:

  • Oculus Quest - Android 7.1.1
  • HTC Vive Focus - Android 7.1.2
  • Pico Neo2 - Android 8.1.0

[Prerequisites]:

  • The Firefox Reality browser is open.

[Steps to reproduce]:

  1. Open the Add-ons page from Library and install the Privacy Badger add-on.
  2. Click the "Okay, Got it" button after the add-on is installed prompt.
  3. Reopen the Add-ons page from Library.
  4. Click on the Privacy Badger card to open the Manage add-on page.
  5. Click the "Remove Add-on" button and observe the behavior.

[Expected results]:

  • The add-on is removed and the Add-ons page is displayed.

[Actual results]:

  • The add-on is removed and the Add-ons page is dismissed.

[Additional Notes]:

  • I wasn't able to reproduce this issue while the Privacy Badger Thank You page was not displayed in the background.
  • Attachments for the issue:
    • Screen Recording: link.
@Softvision-RemusDranca Softvision-RemusDranca added [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Caught_by_exploratory Bugs found during exploratory testing labels Aug 14, 2020
@keianhzo keianhzo self-assigned this Aug 18, 2020
@keianhzo keianhzo mentioned this issue Aug 18, 2020
Merged
keianhzo added a commit that referenced this issue Aug 18, 2020
@keianhzo
Fixes #3812 Fixes #3813 Add-ons tabs life cycle fixes (#3821)
3afa6fa 
* Addons tabs fixes

* Addons List refresh fixes

* Handle Addon tabs state updates
@Softvision-RemusDranca
Copy link
Author

I have verified this issue and it's no longer reproducible using the Firefox Reality 12 RC2 (195415f). The Library is no longer dismissed after removing the add-on while the Thank You page is displayed in the background

Tested on Oculus Quest (Android 7.1.1), HTC Vive Focus (Android 7.1.2) and Pico Neo2 (Android 8.1.0).

@Softvision-RemusDranca Softvision-RemusDranca added the [QA]:Verified fixed Label for QA to mark verified fixed issues label Aug 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
[QA]:Caught_by_exploratory Bugs found during exploratory testing [QA]:Normal issue Label for QA to mark normal issues logged [QA]:Verified fixed Label for QA to mark verified fixed issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3812 Fixes #3813 Add-ons tabs life cycle fixes MozillaReality/FirefoxReality
2 participants
@keianhzo @Softvision-RemusDranca