Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

need a better way to show/hide popups and other UI #2307

Closed
jvonitter opened this issue Nov 18, 2019 · 1 comment · Fixed by #2468
Closed

need a better way to show/hide popups and other UI #2307

jvonitter opened this issue Nov 18, 2019 · 1 comment · Fixed by #2468
Assignees
@keianhzo
Labels
in progress
Milestone
#8 features

Comments

@jvonitter
Copy link
Contributor

jvonitter commented Nov 18, 2019 •
edited
Loading

We get a lot of bugs that boil down to "this piece of UI doesn't disappear when it should", primarily with popups. See bugs like #2301 as an example.

There should be a way to easily and reliably hide UI based on user actions, without having to control each other piece of UI individually.
@jvonitter jvonitter self-assigned this Nov 18, 2019
@jvonitter jvonitter added this to the #8 features milestone Nov 18, 2019
@keianhzo
Copy link
Contributor

#2351 have probably alleviated this issue but would be great to audit every dialog/widget as part or together with #2131

@jvonitter jvonitter removed their assignment Dec 2, 2019
@keianhzo keianhzo self-assigned this Dec 3, 2019
@keianhzo keianhzo mentioned this issue Dec 13, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@keianhzo keianhzo

Labels
in progress
Projects
None yet
Milestone
#8 features
Development

Successfully merging a pull request may close this issue.

Dialogs refactoring MozillaReality/FirefoxReality
2 participants
@keianhzo @jvonitter