Skip to content
This repository has been archived by the owner on Jul 22, 2024. It is now read-only.

FxR cross app dialog standarization #2131

Closed
9 tasks done
keianhzo opened this issue Nov 4, 2019 · 2 comments · Fixed by #2468
Closed
9 tasks done

FxR cross app dialog standarization #2131

keianhzo opened this issue Nov 4, 2019 · 2 comments · Fixed by #2468
Assignees
Milestone

Comments

@keianhzo
Copy link
Contributor

keianhzo commented Nov 4, 2019

Is your feature request related to a problem? Please describe.
Dialogs in the app are using different styles that cause consistency issues. We should standardize the dialog styles based on the latest spec: https://trello.com/c/25qaflLv/400-sl-7-componentsdialogs

  • Permissions
  • Restart
  • PopUp Blocking
  • Crash dialog
  • Remove Max Windows dialog
  • Collect Voice samples
  • What's new
  • Sign out
  • Voice Search

Describe the solution you'd like
Create base dialog styles and reuse them in the different dialogs.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@keianhzo keianhzo added this to the #7 polish milestone Nov 4, 2019
@keianhzo keianhzo self-assigned this Nov 4, 2019
@jvonitter
Copy link
Contributor

@keianhzo do you have a size estimate for this?

@keianhzo
Copy link
Contributor Author

@jvonitter added!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants