This repository has been archived by the owner on Jul 22, 2024. It is now read-only.
Megazord configuration for native Rust libraries #1397
Assignees
Milestone
Comments
|
Changes to how megazords are consumed are coming in mozilla-mobile/android-components#3806, so let's wait for that to land. |
grigoryk
pushed a commit
to grigoryk/FirefoxReality
that referenced
this issue
Jul 18, 2019
(currently built against local versions of a-c, since upstream work is still inflight) This PR upgrades a-c to 5.0.0, which is now using 0.35.0 appservices release that introduces a "default megazord", which is what the consuming application now uses by default. See megazord docs: https://mozilla.github.io/application-services/docs/applications/consuming-megazord-libraries.html TODO - we want to use Gecko's network stack
grigoryk
pushed a commit
to grigoryk/FirefoxReality
that referenced
this issue
Jul 18, 2019
(currently built against local versions of a-c, since upstream work is still inflight) This PR upgrades a-c to 5.0.0, which is now using 0.35.0 appservices release that introduces a "default megazord", which is what the consuming application now uses by default. See megazord docs: https://mozilla.github.io/application-services/docs/applications/consuming-megazord-libraries.html TODO - we want to use Gecko's network stack
Merged
|
Is this required for v6 and FxA? Is it still on track or can we push it to v7? |
Merged
|
Megazord wasn't fully integrated. Addressed in #2129 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
To efficiently consume multiple appservices libraries, a megazord configuration is necessary.
Currently only
libplacesis being used, for bookmarks storage.#1389 adds a dependency on
libfxaclientas well, and we'll needlibloginsas well for #1394 and password management.And so, we need to use a "megazord" which contains all the libraries we're using, compiled together.
In the near future consuming non-megazord appservices libraries will not be supported, so this needs to happen on a fairly quick timeline.
The actual work should be fairly straightforward: configuration gradle module substitutions, rust logging, and initializing megazord with a
concept-fetchclient implementation (e.g. gecko fetch client). Follow either whatreference-browserorfenixare doing here.The text was updated successfully, but these errors were encountered: