-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify button styles (Part 1) #2912
Conversation
@sabrinang this is ready for final design review. Please verify changes on review app as well as confirm the UI differences Percy flagged are all intended. |
I will assign people for code review once this has passed design review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class names, hover states, icon transition and colours look good 👍
(using sentence case for button labels is also a best practice for CMS editors)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few requests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💥 🚀 👾 💯
Related to #2905 (To-be-filed Part 2 PR will close it)
Part 1 Work (this PR)
Changes
Button Arrangement
part as that part is best practice for designers and CMS editors)class LinkButtonBlock
: added new button options & updated all instances of that block use viacontext
.btn-
as the classname prefix (instead of.button-
as documented in the original ticket)To code reviewer
Please focus on changes in the following files. Changes in other files are just find-and-replace class name updates.
.scss
files,network-api/networkapi/wagtailpages/customblocks.py
,network-api/networkapi/wagtailpages/templates/wagtailpages/blocks
Part 2 Work (as follow-up #2936)
btn-normal
andbtn-ghost
fromclass LinkButtonBlock