Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify button styles (Part 1) #2912

Merged
merged 25 commits into from
Apr 1, 2019
Merged

Unify button styles (Part 1) #2912

merged 25 commits into from
Apr 1, 2019

Conversation

mmmavis
Copy link
Collaborator

@mmmavis mmmavis commented Mar 28, 2019

Related to #2905 (To-be-filed Part 2 PR will close it)

Part 1 Work (this PR)

Changes

  • addressed everything mentioned in Unify button styles #2905 (expect the Button Arrangement part as that part is best practice for designers and CMS editors)
  • class LinkButtonBlock: added new button options & updated all instances of that block use via context
  • we have decided to have .btn- as the classname prefix (instead of .button- as documented in the original ticket)

To code reviewer

Please focus on changes in the following files. Changes in other files are just find-and-replace class name updates.

  • .scss files,
  • network-api/networkapi/wagtailpages/customblocks.py,
  • and network-api/networkapi/wagtailpages/templates/wagtailpages/blocks

Part 2 Work (as follow-up #2936)

  • remove old options btn-normal and btn-ghost from class LinkButtonBlock

@cadecairos cadecairos temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 00:30 Inactive
@mmmavis mmmavis had a problem deploying to foundation-mofostaging-pr-2912 March 28, 2019 00:32 Failure
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 00:33 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 00:53 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 01:02 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 01:05 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 18:20 Inactive
@mmmavis mmmavis changed the title (WIP) Unify button styles (WIP) Unify button styles (Part 1) Mar 28, 2019
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 18:25 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 23:46 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 28, 2019 23:56 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 20:05 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 22:30 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 22:42 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 23:09 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 23:11 Inactive
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 March 29, 2019 23:15 Inactive
@mmmavis mmmavis changed the title (WIP) Unify button styles (Part 1) Unify button styles (Part 1) Mar 29, 2019
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 29, 2019

@sabrinang this is ready for final design review. Please verify changes on review app as well as confirm the UI differences Percy flagged are all intended.

@mmmavis mmmavis requested a review from sabrinang March 29, 2019 23:25
@mmmavis
Copy link
Collaborator Author

mmmavis commented Mar 29, 2019

I will assign people for code review once this has passed design review.

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 April 1, 2019 16:52 Inactive
Copy link

@sabrinang sabrinang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class names, hover states, icon transition and colours look good 👍
(using sentence case for button labels is also a best practice for CMS editors)

@mmmavis mmmavis requested a review from Pomax April 1, 2019 17:34
Pomax
Pomax previously requested changes Apr 1, 2019
Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few requests

@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 April 1, 2019 22:01 Inactive
@mmmavis mmmavis requested a review from Pomax April 1, 2019 22:01
@mmmavis mmmavis temporarily deployed to foundation-mofostaging-pr-2912 April 1, 2019 22:26 Inactive
@mmmavis mmmavis dismissed Pomax’s stale review April 1, 2019 22:26

PR updated

Copy link
Contributor

@Pomax Pomax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💥 🚀 👾 💯

@mmmavis mmmavis merged commit 122b479 into master Apr 1, 2019
@mmmavis mmmavis deleted the issue-2905-button-style branch April 16, 2019 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants