8001 Listing block adjustments #11540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinhowbrook
commented
Dec 13, 2023
tbrlpld
reviewed
Dec 13, 2023
network-api/networkapi/wagtailpages/pagemodels/customblocks/listing.py
Outdated
Show resolved
Hide resolved
network-api/networkapi/wagtailpages/templates/wagtailpages/blocks/listing_block.html
Outdated
Show resolved
Hide resolved
Comment on lines
28
to
35
| {% if card.category %} | ||
| <div class="tw-px-0"><p class="tw-h6-heading tw-text-blue-80 tw-mr-2 tw-py-2 tw-mb-0">{{ card.category }}</p></div> | ||
| {% endif %} | ||
| {% if card.date_meta %} | ||
| <div class="tw-px-2"><p class="tw-h6-heading tw-text-gray-40 tw-py-2 tw-mb-0">{{ card.date_meta }}</p></div> | ||
| {% endif %} |
There was a problem hiding this comment.
I think the padding divs would lead to a layout issue of only the date is shown, because we have that padding.
Maybe we can simplify this by using the flex box gap property instead of using padding and wrappers?
There was a problem hiding this comment.
Chris has a ticket to tidy this up because my FE is terrible
|
I am also surprised to see the body content is blue in the screenshots. Where does that come from? |
6 tasks
Yea I think it's the link wrapping behaviour if a link is set. Chris has a ticket to address this stuff |
Base automatically changed from
feature/9282-stats-block
to
integration/mozfest-2024
December 14, 2023 10:50
779902c to
d30d371
Compare
d30d371 to
2a749a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds fields to the Listing block to fulfil the new mozfest design requirements:
Link to sample test page: http://mozfest.localhost:8000/en/landing-page-1/
Design: https://www.figma.com/file/qfVqiUyj10U1jL6Km50YIh/MozFest-2024?type=design&node-id=430-17047&mode=design&t=WjYYpgaHT9gPjN0s-4
Related PRs/issues: https://torchbox.monday.com/boards/1334760528/pulses/1342358011
Checklist
Tests
Changes in Models:
Documentation:
Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main