Newsletter #86
Newsletter #86
Conversation
|
@laurafitzgerald can you please review this when you have the time? :) |
There was a problem hiding this comment.
@evanhearne This looks great. The pages are working as expected. The only feedback would be to maybe chat with the stakeholders about the layout of the landing newsletter page where you have the drop down. We could perhaps make that look a little nicer. Functionally this works great! Couple of issues with the git commits in the pr but let's address that in an upcoming session. I think we can go over that again. If you want to try to squash the 8 commits you can do that. But I will leave that up to you. For a change like this it would make sense to only have 1 commit there.
changed preview link added newsletter
42c01f0 to
c563e32
Compare
|
@laurafitzgerald I squashed the commits, but for some reason it says I dismissed your stale review. I found this link that supposedly tells you to fix this. isaacs/github#1157 (comment) Meanwhile could you reapprove this branch so I can merge? |
There was a problem hiding this comment.
@evanhearne I see that you've squashed the commits now. I double checked it's still all working. Feel free to merge. 👍
|
@evanhearne I put a new setting over the weekend to dismiss an approval review on a force push. It's just another security approach in order to get changes verified again once a force push happens, just in case there is some problem with the force push. |
|
@laurafitzgerald thanks for that. Merging now. :) |
Description
Newsletter Feature added to the website.
What
January 2019 Newsletter is available.
Why
Parents can now see Newsletters online
Verification Steps
http-server it, see if
Newsletteris present on the navbar. Page should show up with dropdown to Jan 2019 newsletterChecklist: