Reexecute-blocks clean up #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notlesh
added a commit
that referenced
this pull request
Aug 15, 2024
…strange#306) * Feature: RPC-based state reader for Blockifier reexecution Problem: we need a way to reexecute blocks with Blockifier. Solution: implement the `StateReader` trait using the `starknet-rs` crate to fetch all the relevant data from a Pathfinder node. * test * include ABI in serialization * move code * remove prove_block state reader * rename to rpc-replay * Add test case for failing deserialization * Compile sierra class -> CASM when fetching class from Pathfinder RPC * Print anyhow error verbosely * Add sierra->compile->hash test * A class hashing fn that works! * Feature: support visited PCs Problem: the code needed to only partially load programs based on visited PCs was left as a TODO. We were wondering if this code could be the cause of some hashing issues. Solution: implement bytecode segment loading properly. We should now support visited PCs to a reasonable extent. * clippy * fix IS_LEAF hint * use visited pcs by default * Include visited_pcs in prove_block * Use compiled class hash instead of class hash as compiled_classes key * Get bytecode segment as impl from exec_scopes * Implement ITER_CURRENT_SEGMENT_INFO hint * Fill out transaction class_hash when we can * Fill in class_hash_to_compiled_class_hash * Fix integration tests * Query class proof from Pathfinder RPC * Ensure class_hash is available when creating new ContractState * Remove nonce-deduction code * Copy build_starknet_storage_async to build contract storage * Fix compile issues * Fix compiler warnings * Clean up creation of contract states and storages * Feature: make OS per-contract storage customizable Problem: we are facing issues integrating the model of `OsSingleStarknetStorage` with Pathfinder, as we do not have a method to traverse the tree to reach arbitrary leaves. Solution: Make the OS generic on the per-contract storage type instead of just the storage. This allows users to further customize the behaviour of the OS when it comes to storage. * fmt * Impl PerContractStorage in prove_block * Couple fixes for per contract storage impl * fmt * fmt * Remove useless comment * Remove massive test json * clippy * Fix bytecode segments test * Ressurect ContractClassForPathfinderCompat * fmt * Reexecute-blocks clean up (#19) * Move process_function_invocations() out of main() * Remove debug logging * Fail fast when txn has no sender_address * Remove stale comment * Use ffc_for_class_hash instead of clone_with_different_hash() * Remove verbose class hash logging * Query class proofs at previous block * Not afraid of Carpal tunnel * Add TODO about fetching classes at current block * fmt --------- Co-authored-by: Olivier Desenfans <desenfans.olivier@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a PR for cleaning up keep-starknet-strange#306 and handling PR feedback.
Issue Number: N/A
Type
Description
Breaking changes?