Use set_storage_at instead of storage_view #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
0054966 is off-topic, but it's a valid fix. |
notlesh
commented
Apr 22, 2024
| let storage_view = &mut state.state.storage_view; | ||
|
|
||
| storage_view.insert((block_hash_contract_address, block_number), block_hash); | ||
| state.set_storage_at(block_hash_contract_address, block_number, block_hash).unwrap(); |
There was a problem hiding this comment.
This is the original "on topic" fix
|
Cleaned up and PRed upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this fixes the tree traversal issue with the block_number storage.
Note that now we traverse into
traverse_empty()instead oftraverse_edge()for this node.Issue Number: N/A
Type
Description
Breaking changes?