Let "Replace runner" work with orgs #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When replacing an existing runner, it makes no sense to restrict it to not run on org runners. This commit removes that requirement closes: MonolithProjects#207
|
I think this resolves #145 too |
b33b8e0
into
MonolithProjects:master
4 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When replacing an existing runner, it makes no sense to restrict it to not run it on org runners. This commit removes that requirement.
If there is a hidden assumption that requires it to not run on orgs, please let me know :)
Potentially closes: #207 and #198
Type of change
How Has This Been Tested?
I tested this by deploying the role to my infrastructure multiple times, with
reinstall_runner: trueRecreating a github runner is still "failing" because it is trying to redo the service files that are already installed, but it sets up the runner correctly