Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes ability for players to initiate vote on storytellers #701

Merged
merged 4 commits into from
Dec 14, 2023

Conversation

lmenvs
Copy link
Collaborator

@lmenvs lmenvs commented Dec 11, 2023

About The Pull Request

Players can no longer initiate storyteller votes. They can still participate in them.

Why It's Good For The Game

stops spam

Changelog

🆑
del: Players can no longer initiate storyteller or map votes.
/:cl:

@lmenvs lmenvs changed the title Removes ability for players to vote on maps and storytellers Removes ability for players to initiate vote on maps and storytellers Dec 11, 2023
@LikeLakers2
Copy link
Collaborator

LikeLakers2 commented Dec 11, 2023

Code changes outside the /monkestation/ folder need to be marked appropriately - or ideally, those changes should be made using modular overrides within the /monkestation/ folder. See https://github.com/Monkestation/Monkestation2.0/blob/master/monkestation/README.md for more information.

@lmenvs
Copy link
Collaborator Author

lmenvs commented Dec 12, 2023

Code changes outside the /monkestation/ folder need to be marked appropriately - or ideally, those changes should be made using modular overrides within the /monkestation/ folder. See https://github.com/Monkestation/Monkestation2.0/blob/master/monkestation/README.md for more information.

Added comments where necessary. My changes on the remaining files outside of the monkestation folder removed borbop's old code, so that is technically unchanged from tg.

@lmenvs lmenvs changed the title Removes ability for players to initiate vote on maps and storytellers Removes ability for players to initiate vote on storytellers Dec 12, 2023
@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 12, 2023

if everything in this is how i read it, it looks ok for a tm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants