Fixes basic mobs targeting ventcrawling/jaunting mobs #5648
+28
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## About The Pull Request see title - changes an isturf check to an !ismob check for an attacking basic mob's loc in can_attack(), as previously this allowed mobs to shoot from inside containers ## Why It's Good For The Game  ## Changelog :cl: fix: Basic mobs no longer have the (unintended) ability to shoot out of containers, like bluespace body bags. /:cl: --------- Co-authored-by: Hatterhat <Hatterhat@users.noreply.github.com> Co-authored-by: Ghom <42542238+Ghommie@users.noreply.github.com>
This was referenced Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Fixes #4873
This makes it so basic
/datum/targeting_strategy/basicwon't consider any targets withTRAIT_MOVE_VENTCRAWLINGorTRAIT_MAGICALLY_PHASEDto be valid targets - and thus, won't attack them.I also did some slight code cleanup.
The code is not modularized bc I will port this upstream if it works (I don't see any reason why it wouldn't either)
Also ports tgstation/tgstation#81804.
Why It's Good For The Game
bugfix good
Changelog
🆑
fix: AI-controlled basic mobs will no longer somehow attack people who are ventcrawling or jaunting.
fix: (Hatterhat) Basic mobs no longer have the (unintended) ability to shoot out of containers, like bluespace body bags.
/:cl: