-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add support for preloading the icon_exists
cache
#5530
Conversation
As an aside - I might suggest putting this preloading functionality behind a compile-time flag... let's say Then, if this flag is specified, we call into a new implementation of
This avoids running code specific to the preloaded cache version, if we aren't using it (or otherwise don't want it) - and simultaneously, speeds up the preloaded cache version by not trying to populate the cache should the file not exist. This, in turn, keeps |
// #define DISABLE_DREAMLUAU | ||
|
||
/// If this is uncommented, /proc/icon_exists will attempt to load an initial cache from icon_exists_cache.json | ||
// #define PRELOAD_ICON_EXISTS_CACHE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW I wouldn't mind this being uncommented by default, if you think it'd be better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
currently there's not even a build step to do this, i'm doing this manually / via TGS build scripts
About The Pull Request
uses https://github.com/absolucy/icon-presence-cache
Why It's Good For The Game
better performance
Changelog
no player-facing changes