Storyteller rebalance and modularization. (And two more storytellers) #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2023
| /datum/round_event_control/operative | ||
| track = EVENT_TRACK_MAJOR | ||
| tags = list(TAG_DESTRUCTIVE, TAG_COMBAT, TAG_EXTERNAL) | ||
| checks_antag_cap = TRUE |
There was a problem hiding this comment.
This should not check antag cap as its meant to be a safeguard.
There was a problem hiding this comment.
Also might be good to remove its tags.
This was referenced Nov 22, 2023
This was referenced Nov 22, 2023
This was referenced Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Modularizes all the event overrides.
Adds some extra tags to some antags(read: Ninja and carp)
Jester+Warrior are now medium/highpop only.
Adds two storytellers:
The Hermit
The Hermit will create mostly internal conflict around the station, and rarely any external threats.
The Nobleman
The Nobleman enjoys a good fight but abhors senseless destruction.
Why It's Good For The Game
Jester + Warrior just spam the same events over and over again on lowpop, causing people to get burnt out easily.
The reason for the player limit of 40 is because its based on server pop, not readied players, the amount of players readied is usually ~10 less than server pop.
Ninja and carp are both destructive events.
The Nobleman creates a good balance between the warrior's combat focus and the sleeper's focus on non-destructive gameplay that allows non-combatants to enjoy the game too.
The Hermit is good for those who prefer intrigue and internal conflict.
Changelog
🆑
add: The Observer, a more roundstart focused storyteller that prefers to watch idly
add: The Nobleman, a less destructive variant of warrior that lets pacifists enjoy the game too.
qol: No more lowpop kudzu spam
balance: Jester and warrior are now highpop/midpop only.
balance: Changed a lot of storyteller tags to make more sense
code: Modularizes a lot of storyteller code
/:cl: