Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feburary Fixes part 2 #5409

Merged
merged 7 commits into from
Feb 12, 2025
Merged

Feburary Fixes part 2 #5409

merged 7 commits into from
Feb 12, 2025

Conversation

Coll6
Copy link
Contributor

@Coll6 Coll6 commented Feb 10, 2025

About The Pull Request

Another set of easy fixes I could find on the issue tracker.
Radio component now correctly triggers and receives and uses its cool-down #5295 and #4595
Tirizine adjusted for monkestation higher max stamina and stamina regen values. fixes #4171
initial 15 -> 45 stamina damage, minimum 3 -> 9 stamina damage.
Money component can now accept money and properly fires a signal to other components when paid fixes #4211
Beach ruins uses an old jukebox that requires bar access that the beach bum doesn't have. It is replaced with the more public station jukebox which most have access to. fixes #700

Why It's Good For The Game

Mostly another set of fixes for the game. I find it a bit cathartic to remove them especially one line changes.

  1. The radio component is supposed to be wiremod circuits version of the remote signaler mostly its just an in icon as is.
  2. Tirizene is a chem that was not adjusted for monkestation stamina values making it useless as it came from a place that had much lower thresholds. Adjusted them to be closer to how it should be.
  3. Money component needed an object flag so it could actually be hit. Then needed to be told to fire its signal message so it could trigger other components
  4. Beach bum had no access to their own jukebox no rad tunes. Also based on the issue the one there didn't have many songs if at all. Swapping it to the more public maintained one on station solves this. Rad.

Changelog

🆑 Siro
fix: wiremod radio circuit now receives and triggers as it should.
fix: Money mechcomp component now accepts money and fires signals as it should.
fix: Beach ruins now uses station public jukebox. Now all can use it.
balance: Tirizine values buffed for monkestation stamina adjustments.
/:cl:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fix fix da bug Minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the payment component Trizene don't work Beach Bum Bartender can't use jukebox
3 participants