Refactors silicon emotes slightly - port of tgstation 84912 #5384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
There was a small bug - creatures with synthetic voice boxes (IPCs, people with robot voicebox) were unable to use *beep due to a strange configuration of can_run_emote with monke modularity. I took a look at it, and it seemed like a good time to port this PR: tgstation/tgstation#84912
This essentially moves the check to a trait, and that trait is added to silicons, synthetic tongue organs, bots, and brains (posibrain/MMIs).
Why It's Good For The Game
Code's a bit cleaner in terms of defining who can use silicon emotes, and this fixes a bug with using *beep as a carbon with a synthetic voice box.
Changelog
🆑
refactor: Refactored the way silicon emotes are handled in silicons, robots, and synthetic voiceboxes
fix: synthetic voiceboxes can *beep again!
/:cl: