Mining RND #2 : New PKA Varients

[Salted-Zen]

About The Pull Request

Finally, the second edition of Mining RND shenanigans is here! Introducing not four, but SIX new PKA varients. After the success of the four new crusher varients, the Mining RND team was given enough funding for a pizza party, which somehow resulted in even more work getting done!

This adds six new PKA varients - The railgun, The Repeater, The Shotgun, The Pistol, The Pounder, and The Grenade Launcher.

The Railgun trades customization, fire rate, and storage capabilities for the ability to fire a high damage shot that penetrates creatures! Has a special firing pin that denies use anywhere but mining zones.

The Repeater trades mod space and a bit of damage for the ability to fire three shots in rapid succession before needing to recharge, while also doing more damage than base PKA if all three shots are landed.

The Shotgun fires a short range set of three rounds that does more damage than base PKA if all three shots land. This trades mod capacity and cooldown speed.

The Pistol trades base damage, and range, for double mod capacity, making it a truely customizable PKA.

The Shockwave takes a higher cooldown and no range in return for creating a 3x3 blast of Kinetic Projectiles around you that do the same damage as a base PKA.

The Grenade Launcher fires the same bombs as the mining mod suit, without needing the modsuit (obviously). It has the same firing pin as the railgun denying anywhere but mining zones. no modifications.

Adds previously mentioned wastes firing pin too that cant be removed or created, meant to go into weapons to restrict their use to only mining zones (lavaland, icemoon wastes)

Also adds two meme weapons the mining RND team accidently created when the fabric of space time got ripped open by a janitor slipping on a banana pizza.

The adminium reaper which utterly destroys anyone and anything it hits, and the adminium stunner than absolutely stunlocks and bullies the target.

Please just test merge for balance purposes : everything needs new inhand sprites though thats low priority

Why It's Good For The Game

After adding new Crusher weapons, it was time for PKA to get its turn, so im back to make it happen - Jekyll : Mining RND Director

Changelog

🆑
add: SIX NEW PKA VARIENTS - Shotgun, Pistol, Railgun, Grenade Launcher, Shockwave, Repeater
add: Wastes firing pin, denies use anywhere but mining zones, cant be removed.
/:cl:

[DexeeXI]

At this moment, LINTERS is failing:

Error: /obj/projectile/proc/on_entered calls /obj/projectile/proc/on_hit which has override child proc that sleeps /obj/projectile/hook/mining/proc/on_hit

Oshan failed becuase its Oshan.

[Salted-Zen]

At this moment, LINTERS is failing:

Error: /obj/projectile/proc/on_entered calls /obj/projectile/proc/on_hit which has override child proc that sleeps /obj/projectile/hook/mining/proc/on_hit

/obj/projectile/hook/mining/on_hit(atom/target)
. = ..()
var/atom/A = target
A.visible_message(span_danger("[firer] zips towards [A] as the hook latches on!"))
ADD_TRAIT(firer, TRAIT_MOVE_FLYING, null)
new /datum/forced_movement(firer, A, 10, TRUE)
sleep(0.5 SECONDS)
REMOVE_TRAIT(firer, TRAIT_MOVE_FLYING, null)

This is what I have. I believe the sleep is causing the issue potentially, but I don't know what alternative to use to it, because without it, the flying trait is instantly removed, meaning you cant pass over lava with the grapple hook without taking damage.

[dwasint]

At this moment, LINTERS is failing:
Error: /obj/projectile/proc/on_entered calls /obj/projectile/proc/on_hit which has override child proc that sleeps /obj/projectile/hook/mining/proc/on_hit

/obj/projectile/hook/mining/on_hit(atom/target) . = ..() var/atom/A = target A.visible_message(span_danger("[firer] zips towards [A] as the hook latches on!")) ADD_TRAIT(firer, TRAIT_MOVE_FLYING, null) new /datum/forced_movement(firer, A, 10, TRUE) sleep(0.5 SECONDS) REMOVE_TRAIT(firer, TRAIT_MOVE_FLYING, null)

This is what I have. I believe the sleep is causing the issue potentially, but I don't know what alternative to use to it, because without it, the flying trait is instantly removed, meaning you cant pass over lava with the grapple hook without taking damage.

use a timer ie addtimer(CALLBACK(src, PROC_REF(remove_flight), firer),0.5 SECONDS)

[Salted-Zen]

got rid of the sleep line... and resolved the issue by just using forcemove instead of a code nightmare of granting and removing flight

[Salted-Zen]

Slight issue, zip hook dosn't work at all on live, but in debug it does.