Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes TWitch from normal rounds, and blacklists key chems from stra #4626

Merged
merged 4 commits into from
Jan 7, 2025

Conversation

OliverOtter
Copy link
Contributor

@OliverOtter OliverOtter commented Dec 20, 2024

Be me
Admin shift, time to pull up big boy pants
Observe some people with sandevistan effect
Examine more and realize its TWitch chem
Test with TWitch chem, realize OD'ing gives you a 100% projectile dodge chance, while giving meth speed, that IS stackable with meth.
You can create it pretty easily, and strange seed it.
MFW
thisshiteveryday

About The Pull Request

As the story implies, nerfs strange seeds by adding a blacklist for certain chemicals. And makes TWitch an admin only chemical.

Why It's Good For The Game

I dont think i need to explain how meth speed + projectile immunity is inherently unhealthy, especially with little downsides and easy (with some smarts) access. Also, we dont need botany to grow adminordrazine banana's. They're already strong as is. This doesnt remove it, nor the autoinjector form the game, but makes it admin only.

Changelog

🆑
balance: Blacklisted spesific antag and admin reagents from strange seeds.
balance: Changed the recipe for TWitch, making it effectivly impossible to get. If you somehow make it, you earned it.
del: Removed the TWitch injector from a hacked ordering computer.
admin: Added a warning to the TWitch autoinjector OPFOR item.
/:cl:

@github-actions github-actions bot changed the title Removes TWitch from normal rounds, and blacklists key chems from stra… Removes TWitch from normal rounds, and blacklists key chems from stra Dec 20, 2024
/datum/reagent/impedrezene = 5,
/datum/reagent/bluespace = 10,
/datum/reagent/consumable/liquidelectricity = 2,
/datum/reagent/medicine/adminordrazine = 30,
Copy link
Collaborator

@wraith-54321 wraith-54321 Dec 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest making it need lavaland reagents instead, that or making it be a secret recipe like metalgen, currently this is a waste of adminordrazine as its still a better chem

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I contemplated on this, but decided not to. Having full projectile immunity is extremely busted, and it's not suppose to be made anyways, which is why it uses adminordrazine.

@@ -71,7 +71,19 @@
var/list/infusion_mutations = list()
///infusion damage
var/infusion_damage = 0

///Blacklist for strange seeds, because botany is already as strong as it is.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be in a modular folder

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll move it when I get home then.

@Kitsunemitsu Kitsunemitsu added Removal a thing is removed Balance perfectly balanced as all things should be labels Dec 20, 2024
@RafRoq
Copy link
Contributor

RafRoq commented Dec 22, 2024

there is already a way to remove chems from strange seeds, remove the REAGENT_CAN_BE_SYNTHESIZED flag from the chem, you don't need to make it admin only, there are a few ways to make something exclusive instead of removing it entirely but adminbus rounds.

I'm not a maintainer but i don't see with good eyes hasty uncreative attempts of nerfs

I also think muscle stimulants should not be blacklisted

@The-Awful
Copy link

Personally I don't really have a huge problem with TWitch, and I can think of a few better ways to nerf it than just... essentially outright removing it? But my main issue here is the fact this also removes a few miscellaneous chems from strange seeds, without really justifying it or mentioning it (save for offhandedly in the changelog).

@Vincent983
Copy link

why not just make it... be like a 50% chance or somethin to ignore projectiles?

@Wernerses
Copy link
Contributor

I think a few comments have already pointed out the problems with this change, and coming from a mentor perspective here, the outright removal of not just the TWitch chem, but others who have yet to been justified is midly concerning and comes in a reactive manner, which is probably not a good way to deal with the problems this chemical is causing.

Some of the most concerning non-explained removals are of

  • Stimulants
  • Muscle Stimulants
  • Meth

These are either helpful for the station, security or provide antags with more opportunities to engage with the enviroment, at the cost of having to carefuly select strange seeds, have a good enough nutriment production and an well upgraded biogen to even achieve this. Furthermore, the removal of meth on strange seeds, but not on omega weed is a confusing subject to me, since from what i've often shown to players, the carefully managing of strange seeds and mixing of chemicals and traits can take far more work than the mutation of weed into omega weed.

I cannot understand why these are on a PR about the removal of TWitch other than that they interact well with the chem. I strongly recommend an nerf to the chemical TWitch or its limitation to lavaland only enviroments, or, if as stated by Raf, an blacklisting of the chemical, as it has seen to be possible on #2342.

I again, from a mentor perspective, strongly suggest a review of the balance of the chemical itself and not the game mechanics of other unrelated chemicals and their interaction with botany, at least on this PR.

@ThePooba ThePooba merged commit bf00cc4 into Monkestation:master Jan 7, 2025
24 checks passed
github-actions bot added a commit that referenced this pull request Jan 7, 2025
Gw0sty pushed a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
…Monkestation#4626)

* Removes TWitch from normal rounds, and blacklists key chems from strange seeds.

* grammer skill issue

* Adding more to the blacklist, removed pen from imports.

* The blacklist didnt work, removing
Gw0sty pushed a commit to Gw0sty/Monkestation2.0 that referenced this pull request Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance perfectly balanced as all things should be Removal a thing is removed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants