Fixes dwarfs and giants for real this time #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does it work with hat stacks too? |
|
it dont :C |
Good catch! It works with the next commit |
Closed
|
Damage and Wound overlays fixed.
|
|
After receiving information about additional issues the gigantism visuals are causing, I'm going back to the old resize = 1.25 method. It's jank, but at least it works. As a side effect since they're using two different methods now I removed the exclusivity, so if people REALLY want, they can be fucked up giant dwarves! |
|
Nevermind. The traits are made exclusive again, and should be permanent once acquired which I didn't realize was desired. I'm just so tired. |
This was referenced Sep 30, 2023
JohnFulpWillard
added a commit
to JohnFulpWillard/Monkestation2.0
that referenced
this pull request
Oct 21, 2024
By fully reverting a PR (Monkestation#363) that became non functional after a few big port PRs overwrote the stuff it did, creating a mess.
ThePooba
pushed a commit
that referenced
this pull request
Oct 31, 2024
* simians are subtypes of monkey * Update humans.dm * Create screenshot_humanoids__datum_species_monkey_simian.png * Update high_five.dm * Revert "Update high_five.dm" This reverts commit 3585b0a. * Fixes simian eyes & pref page image * monkey tail pref icon * Update head.dm * screenshot tests * Update simian.dm * Update simian.dm * Update screenshot_humanoids__datum_species_monkey_simian.png * now advancedtoolusers * ports how TG handles applying height filters This makes it not work in pref menu properly but should hopefully cut down on the amount of times it gets called. * takes the lazy way out to fix hats * all hail the one line fixes * Fixes butchering monkeys/simians * Simian gags is kil * teratomas cant use monkey parts anymore * Adds comments for non modular changes * Fixes belts looking off * Update simian.dm * Monkeys now have fur and eyes * Update monkestation/code/game/objects/items/translation_hat.dm Co-authored-by: wraith-54321 <69217972+wraith-54321@users.noreply.github.com> * updated screenshot tests * cuts down on unnecessary things * Update _species.dm * Less unnecessary calls for updating bodies Monkestation seems to have a lot of unnecessary calls to update body, this cuts down on a few of them. TG's species-nuking PRs might be good to help against this. * one less call to update body parts * Hopefully cuts down more on needless calls By fully reverting a PR (#363) that became non functional after a few big port PRs overwrote the stuff it did, creating a mess. * Update body.dm * removes double regenerate icons call * no need to update body parts every time we change prefs --------- Co-authored-by: wraith-54321 <69217972+wraith-54321@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Once again!
This fixes the messed up dwarf eyes and beards so they line up properly.
It also makes giants use the new height system.
There's also a fix so giants and dwarfs should have their icons update in character customization.
Why It's Good For The Game
Visuals and consistency
Changelog
🆑 KoboldCommando
fix: dwarf beards and eyes should work properly now
fix: giants use the new height system and look a bit less distorted
/:cl: