Even more Bloodsucker fixes, quality-of-life, and code cleanup! #2546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Absolucy
commented
Jul 6, 2024
| @@ -289,10 +294,6 @@ | |||
| return FALSE | |||
| var/disloyalty_requires = RequireDisloyalty(user, target) | |||
|
|
|||
| if(HAS_TRAIT(target, TRAIT_MINDSHIELD)) | |||
There was a problem hiding this comment.
given the fact /obj/structure/bloodsucker/vassalrack/proc/remove_loyalties(mob/living/target) is a thing (it literally does one thing: removes mindshield implants), I assume this check is a mistake, and that mindshielded victims should just fall under VASSALIZATION_DISLOYAL instead
There was a problem hiding this comment.
bloodsucker code is a pile of jank
There was a problem hiding this comment.
the worst part is the pascal cased proc names
|
ADMIN REVIEW: Accepted as it's mostly QoL and balance changes. |
This was referenced Jul 14, 2024
Closed
This was referenced Jul 17, 2024
This was referenced Jul 18, 2024
Closed
Closed
Closed
This was referenced Jul 20, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
🆑
fix: Bloodsuckers can no longer immediately re-enter Frenzy after exiting it (there's a cooldown now).
balance: Frenzied bloodsuckers can't be pushed/slept/stunned. No more falling down mid-snack and ruining your recovery.
spellcheck: Improved the wording and formatting when you examine a frenzied bloodsucker.
fix: Fixed a runtime error relating to vampire organ healing.
qol: The Sleepless Dreamer trauma no longer considers vampires, vassals, "occultist" minds, or SSD people to be viewers.
fix: Fixed various minor things relating to the Archive of the Kindred.
balance: Bloodsuckers now heal brain traumas too, rather than just brain damage.
fix: Bloodsucker organ repair no longer overrides additional properties of their eyes, i.e if they have x-ray eyes.
fix: Antagonists being able to refuse vassalization (at their own peril) now properly works, rather than being a useless prompt that just ignores what you select anyways.
qol: Persuasion rack has more feedback when it doesn't work.
fix: Hopefully fixed bugs related to persuasion rack not working?
fix: IPC/Android bloodsuckers will now actually heal. (MANKIND IS DEAD. BLOOD IS FUEL. HELL IS FULL)
qol: Bloodsuckers will no longer get the negative moodlet or humanity loss from drinking dead blood, if their victim was alive whenever they started feeding.
/:cl: