Rebase Start #1
Closed
Rebase Start #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4df4ae.
dwasint
commented
Mar 19, 2023
There was a problem hiding this comment.
why is this missing? its on my local
dwasint
referenced
this pull request
in dwasint/Monkestation2.0
Aug 22, 2023
…nent (#77539) Hey there, I've personally fallen for this stupid thing twice (in #77503 and #75627 (d357516)), so I decided to spend a few hours to crack out a unit test to ensure that I (and no one else) falls for this stupid thing again. Let me know if there's a smarter way to code something like this, but I couldn't figure out a better way to accomodate the current framework and be as agnostic to certain oddities as possible. Catches stuff like this: ```txt [2023-08-11 21:10:04.019] FAILURE #1: The mob Garden Gnome does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE #2: The mob the morph does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE #3: The mob the guard spiderling (946) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#4: The mob the ambush spiderling (255) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#5: The mob the scout spiderling (375) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#6: The mob the flesh spiderling (337) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#7: The mob the hunter spiderling (869) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#8: The mob the nurse spiderling (629) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#9: The mob the tangle spiderling (19) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#10: The mob the broodmother spiderling (855) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#11: The mob the viper spiderling (519) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#12: The mob the tarantula spiderling (963) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 - FAILURE Monkestation#13: The mob the spiderling (100) does not have ANY instances of TRAIT_SUBTREE_REQUIRED_ELEMENT, but has a planning subtree (/datum/ai_planning_subtree/target_retaliate/to_flee) that requires it! at code/modules/unit_tests/ensure_subtree_element.dm:45 ``` (ignore the part about gnomes and morphs, this was an earlier version of the unit test. everything else was relevant and is fixed) :cl: fix: Growing spiders will now retaliate against you like they were always meant to. /:cl:
dwasint
added a commit
that referenced
this pull request
Sep 18, 2023
Mining RnD #1 : CRUSHER VARIENTS
BYONDFuckery
added a commit
to BYONDFuckery/mothroachstation
that referenced
this pull request
Jul 1, 2024
ThePooba
pushed a commit
that referenced
this pull request
Sep 10, 2024
* New PDA! * brig phys access New Brig Physician access tier. Job support, records * Update Blueshift.dmm ACCESS_BRIG_PHYSICIAN support * Update BoxStation.dmm ACCESS_BRIG_PHYSICIAN support * Update DeltaStation2.dmm ACCESS_BRIG_PHYSICIAN support * Update IceBoxStation.dmm ACCESS_BRIG_PHYSICIAN support * Update KiloStation.dmm ACCESS_BRIG_PHYSICIAN support * Update MetaStation.dmm ACCESS_BRIG_PHYSICIAN support * Update Ouroboros.dmm ACCESS_BRIG_PHYSICIAN support * Update tramstation.dmm ACCESS_BRIG_PHYSICIAN support * Update VoidRaptor.dmm ACCESS_BRIG_PHYSICIAN support * whoops oops haha i fucked up how greyscales work and now we know. AND KNOWING IS HALF THE BATTLE * BP Surgical Bag Newly implemented! Also includes some more fresh descriptions for things, even if it is ultra-instinct basic. * Update records.dm
MomoBerri
added a commit
to MomoBerri/Monkestation2.0
that referenced
this pull request
Oct 5, 2024
ThePooba
pushed a commit
that referenced
this pull request
Oct 25, 2024
…oes and how many runtimes it causes (#2199) * initial commit * Fixes the .DME file, and updates readme.md with the pull number * adds poly achievement sprites * adds the programming console to maps and techweb * fixes the decals being in my walls on kilo * Adds basic signal techs * fixes for jumpsuits and PDA * le fix * adds signal technician start landmarks * TGUI for the NTSL is now a thing * boop for linters * removes skin.dmf NTSL since we use TGUI now * smol fixes * Adds sig techs to ouroboros and void raptor * Ports yog's TGUI traffic console, erasing my work * smol fix * Update tgstation.dme * temp map fixes so linters love me * boop * fixes broadcast() * Update readme.md * adds filter * makes double-spaces become only single-spaces via regex * forces all var.len instances into length() * Update monkestation/code/modules/NTSL/code/coding_language/interpreter/objects.dm Co-authored-by: Lucy <lucy@absolucy.moe> * Update monkestation/code/modules/NTSL/code/coding_language/interpreter/scope.dm Co-authored-by: Lucy <lucy@absolucy.moe> * fixes lucy * uses a giant ass regex to spot most bad symbol placements * Update monkestation/code/modules/NTSL/code/machinery/traffic_control.dm Co-authored-by: Lucy <lucy@absolucy.moe> * smol fix up of + signs * drops ID on being destroyed * telecomms server destroy() cleanup * lucy's freq suggestion thats outdated so i cannot auto-commit it * lucy's Destroy() suggestions * unshittifies north star's 2 message consoles (northstar stays losing) and minor adjustments * fixes rebuilding traffic consoles, changes the AI a lil bit * adds radio as a valid frequency, adds the reference buttong * fixes achievements, fixes NTSL bans not banning you completelly from NTSL * adds specified return types from Lucy's review * adds a singular comment * Minor Cleanup * Job Icon (#1) Gives the signal tech a icon on things like medical records and latejoin menu * adds MONKESTATION ADDITION to job icons * Fixes AI tracking * adds an admin-only button to clear comms * adds plasmamen signal tech clothing --------- Co-authored-by: Lucy <lucy@absolucy.moe> Co-authored-by: Ghosti <83688318+Gw0sty@users.noreply.github.com>
SirNightKnight
added a commit
to SirNightKnight/Monkestation2.0-SNK
that referenced
this pull request
Nov 12, 2024
ThePooba
pushed a commit
that referenced
this pull request
Nov 18, 2024
* more hardsuit sprites * forgot obj sprites of course * uuh more hardsuits, another jetpack, and edits to sec suit unit thingy... i'm tired * so the back had pixels uncovered... great * oh right the digi sprite needed fixing too... * add clown hardsuit to clown's toy chest * explorer job pass #1 first try please? * touch ups on explorer + belt changes * eh? * hardsuit crates! * i should sleep soon * better * fixes a runtime * FUCK
Addust
referenced
this pull request
in addusts-shenanigans/I-am-going-to-defenestrate-myself
Dec 16, 2024
god help me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
Mapping March
Ckey to receive rewards: N/A
Why It's Good For The Game
Changelog
🆑
/:cl: