Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ventcrawling Issue #4255

Open
MonkestationIssueBot opened this issue Nov 15, 2024 · 1 comment
Open

Ventcrawling Issue #4255

MonkestationIssueBot opened this issue Nov 15, 2024 · 1 comment
Labels
bug Something isn't working Minor peak

Comments

@MonkestationIssueBot
Copy link

MonkestationIssueBot commented Nov 15, 2024

Reporting client info: Client Information:
BYOND:515.1646
Key:blightedcliffracer

Round ID:

7867

Testmerges:

Reproduction:

Ventcrawling as a drone in to a scrubber with no pipes attached caused me to get stuck, as I couldn't move anywhere to trigger the auto-climb-out. Resisting did nothing.

@DexeeXI
Copy link
Collaborator

DexeeXI commented Dec 27, 2024

Unsure how we want to approach this one. It is technically working as intended (tm) but leaves smeone in some rather shitty situations. Smart users will check pipes.

@DexeeXI DexeeXI added bug Something isn't working Minor peak labels Dec 27, 2024
MissClassyPineapple pushed a commit that referenced this issue Feb 23, 2025
…con (#5619)

## About The Pull Request
### Enhancements / QoL
- Turns the choice beacon into a small item instead of normal
- Adds large scarfs to the loadout store
### Fixes
- Fixes the top few pixels of anime implant ears getting trimmed for
tallest humans
  - Resized `anime_head.dmi` to be 32x48
- Fixes QMs showing up on lifeline in blueshield mode 
  - #5333
- Fixes having missing / disabled legs slowing down flying players 
  - #4066 
- Fixes ballistic guns with `bolt_type = BOLT_TYPE_NO_BOLT` not deleting
caseless bullets when fired
  - #1651
- Fixes the speen emote not making sound 
  - #4700
- Fixes latejoin borgs with an AI connection being told they are not
linked
  - #4843
- Fixes the muzzle preventing custom emotes
  - #2760 
- Fixes players being unable to resist to get out of vents/scrubbers 
- It could be worth changing how escaping ventcrawling works to require
resisting rather than being automatic, this would allow 'those who vent'
to sit inside vents/scrubbers without getting kicked out after 2.5
seconds.
  - #4255
- Fixes seclights being unattachable to the lawbringer
  - #1402

## Why It's Good For The Game
- I don't believe shrinking the choice beacon should cause any balance
issues, all this change should do is make it easier to keep the beacon
stored and only use it when desired (e.g. for spawning pets or
instruments)
- Let people use large scarfs if they want to!
- Excluding #4255 none of the bugs hurt players too badly but the
codebase would still be better of without them
## Changelog
:cl:
add: added large scarves to the loadout store
qol: shrunk the choice beacon item to be pocket sized
fix: fixed the top few pixels of anime implant ears getting trimmed for
tallest humans
fix: fixed QMs showing up on lifeline's blueshield mode
fix: fixed missing / disabled legs slowing down flying players
fix: fixed the number displayed number of bullets in fingerguns not
decreasing
fix: fixed the speen emote not making sound
fix: fixed latejoin borgs with an AI connection being told they were
unlinked
fix: fixed the muzzle preventing custom emotes
fix: fixed players being unable to resist to get out of vents/scrubbers
while ventcrawling
fix: fixed seclights being unattachable to the lawbringer
/:cl:

---------

Co-authored-by: Xander3359 <66163761+Xander3359@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Minor peak
Projects
None yet
Development

No branches or pull requests

2 participants