When checking for existing phrase, check the group AND key.

[caswd]

This fixed #111 for me.

@digitalcraftlabs maybe my issue is different from yours...

I have a structure like:

lang/
    en/
        authors.php
        posts.php

authors.php looks like this:

return [
    'page_title' => 'Authors',
];

posts.php looks like this:

return [
    'page_title' => 'Posts',
];

When I load it into my database with translations for 'en' and 'nl' (Dutch), the ltu_phrases table looks like:

id	translation_id	phrase_id	key	group
1	1	null	page_title	authors
2	1	null	page_title	posts
3	2	1	page_title	authors

As you can see, I am missing the Dutch phrase for posts.page_title. This is because the query that creates the missing ltu_phrases in the database only check for key, and the key page_title does indeed already exist for the Dutch locale.

[caswd]

After my initial commit I had another issue. My table now looked like:

id	translation_id	phrase_id	key	group
1	1	null	page_title	authors
2	1	null	page_title	posts
3	2	1	page_title	authors
4	2	1	page_title	posts

Which is better.... But as you can see there is still a problem. The phrase_id of the fourth translation is incorrect. It was set to the first match by key, which not the first match by key and group.

My second commit fixes that.

I am wondering tho... Am I the first person to have a structure with many duplicate keys?

I did try the config option include_file_in_key but that open a whole other can of worms, I think that simply isn't compatible with .php translations.

[digitalcraftlabs]

@caswd i see the problem can you please add some test scenarios for this case and push it in the Branch

[caswd]

@digitalcraftlabs that's a good idea! I see none of the commands and actions are tested yet.

I don't have it checked out locally, but I will try to set it up in a Github Codespace to write some tests this weekend. For now, I'm simply using my local modifications in the vendor folder to get the job done 😅

[MohmmedAshraf]

Hi @caswd thank you for the PR, are you going to write tests for this or should i merge it?