Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xResource::withoutWrapping() should not affect JsonResource superclass #144

Conversation

BrianHenryIE
Copy link
Contributor

Where class ContributorResource extends JsonResource, calling the ContributorResource::withoutWrapping() is really calling JsonResource::withoutWrapping() which was then setting the public static $wrap of JsonResource to null, rather than acting on the subclass.

By adding the property to each subclass, calling :withoutWrapping() changes the property only on the subclass and not on the super class.

@BrianHenryIE
Copy link
Contributor Author

Hey. I ran pint before submitting the PR. The workflow action failure seems unrelated:

Screenshot 2025-01-29 at 4 19 34 PM

@MohmmedAshraf
Copy link
Owner

Hey @BrianHenryIE thank you for the PR currently am working on some features and refactor some parts of the code i will merge this soon

@MohmmedAshraf MohmmedAshraf merged commit 506aa0e into MohmmedAshraf:main Feb 3, 2025
4 of 5 checks passed
@MohmmedAshraf
Copy link
Owner

Thank you @BrianHenryIE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants