xResource::withoutWrapping()
should not affect JsonResource
superclass
#144
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where
class ContributorResource extends JsonResource
, calling theContributorResource::withoutWrapping()
is really callingJsonResource::withoutWrapping()
which was then setting thepublic static $wrap
ofJsonResource
tonull
, rather than acting on the subclass.By adding the property to each subclass, calling
:withoutWrapping()
changes the property only on the subclass and not on the super class.