Add irregular time series testing and randomly generated data to current tests. #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CGodiksen
requested changes
Dec 22, 2022
352bfaf to
7ee7526
Compare
CGodiksen
reviewed
Jan 3, 2023
c46c9e5 to
112a00f
Compare
CGodiksen
requested changes
Jan 4, 2023
CGodiksen
approved these changes
Jan 4, 2023
skejserjensen
requested changes
Jan 5, 2023
skejserjensen
requested changes
Jan 7, 2023
… tests to utilize this function.
…nerator more random.
…ess_irregular_constant_time_series and test_try_compress_irregular_almost_constant_time_series).
…a test that ensures the model with the best compression ratio is selected.
…at building on macOS and Windows succeeds.
b260067 to
904841b
Compare
skejserjensen
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a generator for generating random test data and randomized irregular timestamps, new tests for testing irregular time series during compression, and a test to ensure that the selected model has the least amount of bytes. Additional fixes for the macOS and Windows testing environments have also been added to (hopefully) ensure that GitHub checks do not fail again on these platforms.