Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 1976 modifying notice description for invalid currency amount #1988

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Feb 25, 2025

Summary:
Closes #1976

Expected behavior:
html report
image

json report
image

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with gradle test to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Feb 25, 2025 that may be closed by this pull request
@qcdyx qcdyx requested a review from skalexch February 25, 2025 15:35
@emmambd
Copy link
Contributor

emmambd commented Feb 25, 2025

LGTM from a QA side!

Copy link
Contributor

📝 Acceptance Test Report

📋 Summary

✅ The rule acceptance has passed for commit 5843966
Download the full acceptance test report here (report will disappear after 90 days).

📊 Notices Comparison

New Errors (0 out of 1819 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Errors (0 out of 1819 datasets, ~0%) ✅

No changes were detected due to the code change.

New Warnings (0 out of 1819 datasets, ~0%) ✅

No changes were detected due to the code change.

Dropped Warnings (0 out of 1819 datasets, ~0%) ✅

No changes were detected due to the code change.

🛡️ Corruption Check

0 out of 1819 sources (~0 %) are corrupted.

⏱️ Performance Assessment

📈 Validation Time

Assess the performance in terms of seconds taken for the validation process.

Time Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 3.79 3.86 ⬆️+0.08
Median -- 1.36 1.43 ⬆️+0.07
Standard Deviation -- 11.16 11.15 ⬇️-0.01
Minimum in References Reports ph-unknown-hm-transport-inc-and-robinsons-malls-gtfs-1105 0.47 0.55 ⬆️+0.08
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.47 288.74 ⬇️-1.73
Minimum in Latest Reports us-california-catalina-express-gtfs-299 0.48 0.45 ⬇️-0.03
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 290.47 288.74 ⬇️-1.73
📜 Memory Consumption
Metric Dataset ID Reference (s) Latest (s) Difference (s)
Average -- 463.73 MiB 467.87 MiB ⬆️+4.14 MiB
Median -- 335.92 MiB 335.25 MiB ⬇️-688.82 KiB
Standard Deviation -- 762.02 MiB 779.96 MiB ⬆️+17.94 MiB
Minimum in References Reports us-florida-bay-town-trolley-gtfs-337 38.20 MiB 391.92 MiB ⬆️+353.73 MiB
Maximum in Reference Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.93 GiB 11.17 GiB ⬆️+244.40 MiB
Minimum in Latest Reports us-wisconsin-shoreline-metro-gtfs-399 407.92 MiB 39.32 MiB ⬇️-368.60 MiB
Maximum in Latest Reports gb-unknown-uk-aggregate-feed-gtfs-2014 10.93 GiB 11.17 GiB ⬆️+244.40 MiB

Copy link

@skalexch skalexch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qcdyx looks good on the spec side too. I'm glad winning day is having a propagating effect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifying notice description for invalid_currency_amount
3 participants