-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 1725 inconsistent dependency versions across modules #1978
fix: 1725 inconsistent dependency versions across modules #1978
Conversation
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 5957478 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
We need to list all the libraries in the |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit cde318f 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 8666b0b 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 91e59e9 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 7850f6d 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
…f github.com:MobilityData/gtfs-validator into 1725-inconsistent-dependency-versions-across-modules
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 4d2c7b2 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 33973fb 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! This will make library upgrades less painful! I added a few comments before approval.
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 4ecb85a 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 08c4fdb 📊 Notices ComparisonNew Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1811 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1811 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Summary:
Closes #1725
Expected behavior:
resolved version inconsistencies of commons-lang3, auto-service, flogger, flogger-system-backend.
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything