-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: java support for sdk17 #1952
Conversation
🚨 Code Formatting Issue 🚨This contribution does not follow the conventions set by the Google Java Style Guide. Please run the following command at the root of the project to fix formatting errors: ./gradlew spotlessApply 🗂️ Affected files- `src/main/java/org/mobilitydata/gtfsvalidator/cli/Arguments.java`Go to the Actions Dashboard to download the full Spotless output |
This PR introduced this new layout to the code formatting violation comment |
📝 Acceptance Test Report📋 Summary✅ The rule acceptance has passed for commit 666d788 📊 Notices ComparisonNew Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Errors (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. New Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. Dropped Warnings (0 out of 1801 datasets, ~0%) ✅No changes were detected due to the code change. 🛡️ Corruption Check0 out of 1801 sources (~0 %) are corrupted. ⏱️ Performance Assessment📈 Validation TimeAssess the performance in terms of seconds taken for the validation process.
📜 Memory Consumption
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM regarding the question of Google + upgrading to Java 17
Summary:
This PR upgrades Java from 11 to 17. We already used Java 17, but it was inconsistent across all actions, deployments, and artifacts.
The
com.github.sherter.google-java-format
gradle plugin was also a blocker for upgrade, this is why it was replaced by the Spotless plugin, a more active project than the previous.To facilitate the Java libraries upgrade, this PR introduces a default gradle centralized catalog. I added only the required libraries concerning the present PR; the complete alignment of dependencies will be part of #1725.
Part of #1725
Closes #1741
From our AI friend
This pull request includes multiple updates to the GitHub workflows, Dockerfile, and Gradle build files. The primary focus is upgrading the Java version and improving the formatting and validation processes.
Java Version Upgrade:
.github/workflows/acceptance_test.yml
,.github/workflows/docker.yml
,.github/workflows/end_to_end.yml
,.github/workflows/formatting.yml
,.github/workflows/package_installers.yml
,.github/workflows/publish_assets.yml
,.github/workflows/stg_web_client_merge.yml
,.github/workflows/stg_web_svc_merge.yml
,.github/workflows/test_pack_doc.yml
,.github/workflows/web_client_pr.yml
,.github/workflows/web_release.yml
,.github/workflows/web_svc_pr.yml
). [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16]Dockerfile Updates:
Dockerfile
fromgradle:7-jdk11-alpine
togradle:7-jdk17-alpine
and fromopenjdk:11-slim
toopenjdk:17-slim
. [1] [2]Gradle Build File Updates:
com.github.johnrengelman.shadow
plugin version with an alias inapp/gui/build.gradle
andcli/build.gradle
. [1] [2]Formatting and Validation Improvements:
gradle/gradle-build-action
with a Spotless check in.github/workflows/formatting.yml
and added steps to upload Spotless output and comment on PR if the code does not comply with the Google Java style guide.Minor Code Cleanups:
cli/src/main/java/org/mobilitydata/gtfsvalidator/cli/Arguments.java
,core/src/main/java/org/mobilitydata/gtfsvalidator/model/ValidationReport.java
,core/src/main/java/org/mobilitydata/gtfsvalidator/performance/MemoryUsageRegister.java
,core/src/main/java/org/mobilitydata/gtfsvalidator/table/CsvFileLoader.java
,core/src/main/java/org/mobilitydata/gtfsvalidator/table/TableLoader.java
). [1] [2] [3] [4] [5] [6]Expected behavior:
Explain and/or show screenshots for how you expect the pull request to work in your testing (in case other devices exhibit different behavior).
Please make sure these boxes are checked before submitting your pull request - thanks!
gradle test
to make sure you didn't break anything