-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add use_gpu for PureSVD #229
Conversation
6788d67
to
6430038
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #229 +/- ##
===========================================
Coverage 100.00% 100.00%
===========================================
Files 45 60 +15
Lines 2242 4016 +1774
===========================================
+ Hits 2242 4016 +1774 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it looks super cool!
Python 3.9 CI fails because of codecov issue. Test is passed.
|
@feldlime I addressed all the comments you made. PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chezou Sorry for the delay, I added one more small (but critical) comment, and you need to update the changelog one more time (since this change not in the 0.10.0 release), then we're ready to merge
@feldlime Updated the changelog, as well as the order of assignment. |
Description
Introduce
use_gpu
for PureSVD.My microbenchmark code shows 8 times faster than CPU with Movielens 1M dataset on GeForce 3060Ti compared with Ryzen 5 5600X.
Environment information:
Type of change
How Has This Been Tested?
Before submitting a PR, please check yourself against the following list. It would save us quite a lot of time.