Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force USE_BAZEL_VERSION to working SHA until last_green is fixed #3029

Merged
merged 2 commits into from
May 21, 2024
Merged

Force USE_BAZEL_VERSION to working SHA until last_green is fixed #3029

merged 2 commits into from
May 21, 2024

Conversation

thiagohmcruz
Copy link
Contributor

@thiagohmcruz thiagohmcruz commented May 17, 2024 •
edited
Loading

There are at least two issues causing CI to be 🔴 atm:

  1. See example. Repro:
cd examples/integration
bazel clean && USE_BAZEL_VERSION=last_green bazel build //Lib:gen_Lib.swift
  1. See example. Repro:
# From root
bazel clean && USE_BAZEL_VERSION=last_green bazel build //test/internal/bazel_labels:normalize_tests_test_2

I confirmed that bazelbuild/bazel@dd2464a is the last commit that does not hit the issues above. Commit bazelbuild/bazel@3fddc7f is the first one that repros the above (i.e. you'll also hit the issues above if you replace last_green with this SHA).

So proposing we force CI to run on bazelbuild/bazel@dd2464a for now until the issue is fixed upstream. Thoughts?

@thiagohmcruz thiagohmcruz force-pushed the thiago/unblock-genrules-broken-bazel-head branch 2 times, most recently from ca10adb to 4690572 Compare May 17, 2024 18:09
@thiagohmcruz thiagohmcruz changed the title Set no-sandbox in genrules currently broken in Bazel HEAD Set spawn_strategy=standalone to bypass Bazel HEAD issue May 17, 2024
@thiagohmcruz thiagohmcruz changed the title Set spawn_strategy=standalone to bypass Bazel HEAD issue [DNR] Set spawn_strategy=standalone to bypass Bazel HEAD issue May 17, 2024
@thiagohmcruz thiagohmcruz force-pushed the thiago/unblock-genrules-broken-bazel-head branch from 4690572 to 9da0cde Compare May 17, 2024 20:57
@thiagohmcruz thiagohmcruz changed the title [DNR] Set spawn_strategy=standalone to bypass Bazel HEAD issue [DNR] Force USE_BAZEL_VERSION to working SHA until last_green is fixed May 17, 2024
@thiagohmcruz thiagohmcruz changed the title [DNR] Force USE_BAZEL_VERSION to working SHA until last_green is fixed Force USE_BAZEL_VERSION to working SHA until last_green is fixed May 17, 2024
@thiagohmcruz thiagohmcruz marked this pull request as ready for review May 17, 2024 21:09
@thiagohmcruz thiagohmcruz requested a review from a team as a code owner May 17, 2024 21:09
@brentleyjones
Copy link
Contributor

@fmeum seems odd that the identified commit would cause these issues on macOS?

@fmeum
Copy link

fmeum commented May 18, 2024 •
edited
Loading

Yes, that's very much unexpected. I did manually revert seven commits though, it's quite possible I messed something up.

I still have the original version of my PR with many individual commits, I will try to bisect this locally.

Cc @oquenchil as this appears to be a Bazel 7.2.0 regression

@fmeum
Copy link

fmeum commented May 18, 2024

I can't reproduce this locally:

  • bazel clean && USE_BAZEL_VERSION=3fddc7f38ace43981d839ed4558b8a457caf41fb bazel build //test/internal/bazel_labels:normalize_tests_test_2 in the repo root passes.
  • bazel clean && USE_BAZEL_VERSION=3fddc7f38ace43981d839ed4558b8a457caf41fb bazel build //Lib:gen_Lib.swift in examples/integration fails with
ERROR: /Users/fmeum/git/rules_xcodeproj/examples/integration/bazel-output-base/release_archive/external/bazel_tools~xcode_configure_extension~local_config_xcode/BUILD:13:13: in xcode_config rule @@bazel_tools~xcode_configure_extension~local_config_xcode//:host_xcodes: --xcode_version=15C500b specified, but '15C500b' is not an available Xcode version. available versions: [15.4.0.15F31d]. If you believe you have '15C500b' installed, try running "bazel shutdown", and then re-run your command.

I have up-to-date Xcode installed and also ran bazel clean --expunge and bazel shutdown a few times, but am hitting this error persistently.

@fmeum
Copy link

fmeum commented May 18, 2024

I think I found the problem although I'm unable to confirm it, this line is definitely wrong:
https://github.com/bazelbuild/bazel/blame/3fddc7f38ace43981d839ed4558b8a457caf41fb/src/main/java/com/google/devtools/build/lib/sandbox/AbstractSandboxSpawnRunner.java#L375

@fmeum fmeum mentioned this pull request May 18, 2024
Closed
@brentleyjones brentleyjones changed the title Force USE_BAZEL_VERSION to working SHA until last_green is fixed Force USE_BAZEL_VERSION to working SHA until last_green is fixed May 18, 2024
brentleyjones
brentleyjones approved these changes May 18, 2024
View reviewed changes
buildbuddy.yaml Show resolved Hide resolved
copybara-service bot pushed a commit to bazelbuild/bazel that referenced this pull request May 20, 2024
@fmeum @copybara-github
Fix writable sandbox path
b0ed4ca 
The reverts in 3fddc7f accidentally replaced `sandboxExecRoot` with `execRoot` in the function that computes writable directories for sandbox spawn runners.

This issue was observed in MobileNativeFoundation/rules_xcodeproj#3029.

Closes #22443.

PiperOrigin-RevId: 635383877
Change-Id: I3d74bf78cf97ecd267ba90b68cf1b715850aba27
bazel-io pushed a commit to bazel-io/bazel that referenced this pull request May 20, 2024
@fmeum @bazel-io
Fix writable sandbox path
461da24 
The reverts in 3fddc7f accidentally replaced `sandboxExecRoot` with `execRoot` in the function that computes writable directories for sandbox spawn runners.

This issue was observed in MobileNativeFoundation/rules_xcodeproj#3029.

Closes bazelbuild#22443.

PiperOrigin-RevId: 635383877
Change-Id: I3d74bf78cf97ecd267ba90b68cf1b715850aba27
@bazel-io bazel-io mentioned this pull request May 20, 2024
Merged
github-merge-queue bot pushed a commit to bazelbuild/bazel that referenced this pull request May 20, 2024
@bazel-io @fmeum
[7.2.0] Fix writable sandbox path (#22451)
d31ce86 
The reverts in 3fddc7f accidentally
replaced `sandboxExecRoot` with `execRoot` in the function that computes
writable directories for sandbox spawn runners.

This issue was observed in
MobileNativeFoundation/rules_xcodeproj#3029.

Closes #22443.

PiperOrigin-RevId: 635383877
Change-Id: I3d74bf78cf97ecd267ba90b68cf1b715850aba27

Commit
b0ed4ca

Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
@thiagohmcruz
Copy link
Contributor Author

thiagohmcruz commented May 21, 2024 •
edited
Loading

Thx for taking a look @fmeum! I'll address a review comment and land this today in the meantime.

thiagohmcruz added a commit that referenced this pull request May 21, 2024
@thiagohmcruz
Add comment linking to PR #3029
066425f 
Signed-off-by: Thiago Cruz <thiago@squareup.com>
@thiagohmcruz @brentleyjones
Force USE_BAZEL_VERSION to working SHA until last_green is fixed
89f0acd 
Signed-off-by: Thiago Cruz <thiago@squareup.com>
@thiagohmcruz @brentleyjones
Add comment linking to PR #3029
9ebbfe8 
Signed-off-by: Thiago Cruz <thiago@squareup.com>
@brentleyjones brentleyjones force-pushed the thiago/unblock-genrules-broken-bazel-head branch from 066425f to 9ebbfe8 Compare May 21, 2024 16:32
@brentleyjones brentleyjones enabled auto-merge (squash) May 21, 2024 16:32
@brentleyjones brentleyjones merged commit 9a6ec00 into main May 21, 2024
16 checks passed
@brentleyjones brentleyjones deleted the thiago/unblock-genrules-broken-bazel-head branch May 21, 2024 16:37
@thiagohmcruz thiagohmcruz mentioned this pull request May 27, 2024
Merged
brentleyjones pushed a commit that referenced this pull request May 27, 2024
@thiagohmcruz
Force bazel_version in update_all_fixtures.sh to working SHA (#3033)
c72838d 
Similar to:
#3029

Currently the `./test/update_all_fixtures.sh` script is failing with
error (in `main`):
```sh
FATAL: bazel crashed due to an internal error. Printing stack trace:
java.lang.RuntimeException: Unrecoverable error while evaluating node 'ConfiguredTargetKey{label=@@rules_apple~//apple/internal:environment_plist_macos, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}' (requested by nodes 'ConfiguredTargetKey{label=//GRPC:echo_client, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}', 'ConfiguredTargetKey{label=//GRPC:echo_client.merged_infoplist, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}', 'ConfiguredTargetKey{label=//Proto:proto, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}', 'ConfiguredTargetKey{label=//Proto:proto.merged_infoplist, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}', 'ConfiguredTargetKey{label=//GRPC:echo_server, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}', 'ConfiguredTargetKey{label=//GRPC:echo_server.merged_infoplist, config=BuildConfigurationKey[b9d3bb9e7707500dae32d8b693576ca2a5d5e2f8c0d56fe0957bab54bf751df7]}')
        at com.google.devtools.build.skyframe.AbstractParallelEvaluator$Evaluate.run(AbstractParallelEvaluator.java:557)
        at com.google.devtools.build.lib.concurrent.AbstractQueueVisitor$WrappedRunnable.run(AbstractQueueVisitor.java:426)
        at java.base/java.util.concurrent.ForkJoinTask$RunnableExecuteAction.exec(Unknown Source)
        at java.base/java.util.concurrent.ForkJoinTask.doExec(Unknown Source)
        at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(Unknown Source)
        at java.base/java.util.concurrent.ForkJoinPool.scan(Unknown Source)
        at java.base/java.util.concurrent.ForkJoinPool.runWorker(Unknown Source)
        at java.base/java.util.concurrent.ForkJoinWorkerThread.run(Unknown Source)
Caused by: net.starlark.java.eval.Starlark$UncheckedEvalException: IllegalArgumentException thrown during Starlark evaluation (@@rules_apple~//apple/internal:environment_plist_macos)
        at <starlark>.multi_arch_platform(<builtin>:0)
        at <starlark>._platform_prerequisites(/Users/thiago/Development/MobileNativeFoundation/rules_xcodeproj/examples/integration/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_apple~/apple/internal/platform_support.bzl:96)
        at <starlark>._environment_plist_impl(/Users/thiago/Development/MobileNativeFoundation/rules_xcodeproj/examples/integration/bazel-output-base/rules_xcodeproj.noindex/build_output_base/external/rules_apple~/apple/internal/environment_plist.bzl:52)
Caused by: java.lang.IllegalArgumentException: Expected post-split-transition platform type macos to match input macos
```

Keeping an eye on it until the fix is in `last_green`, but working
around it for now to unblock development in `main`.

Signed-off-by: Thiago Cruz <thiago@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentleyjones brentleyjones brentleyjones approved these changes

@mattrobmattrob mattrobmattrob mattrobmattrob approved these changes

@luispadron luispadron luispadron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thiagohmcruz @brentleyjones @fmeum @mattrobmattrob @luispadron