Skip to content

Commit

Permalink
Use --remote_download_outputs=toplevel for projects (#1300)
Browse files Browse the repository at this point in the history
Also stop setting `run:rules_xcodeproj_generator
--remote_download_outputs=all`. This leads to warnings if people set
BwtB settings themselves. They will just have to work around
bazelbuild/bazel#11920 on their own. This also
allows us to immediately benefit if that is eventually fixed.
  • Loading branch information
brentleyjones authored Oct 14, 2022
1 parent 068b576 commit 1f928a9
Show file tree
Hide file tree
Showing 12 changed files with 7 additions and 165 deletions.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 7 additions & 0 deletions shared.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,19 @@ build --remote_default_exec_properties=cache_bust=macOS_12.0/3
# In-repo output_base makes fixtures relative
startup --output_base=bazel-output-base

# Ensure we work with BwtB
build --nobuild_runfile_links
build --experimental_inmemory_jdeps_files
build --experimental_inmemory_dotd_files
build --remote_download_outputs=minimal
test --remote_download_outputs=toplevel

# Work around https://github.com/bazelbuild/bazel/issues/11920
run --remote_download_outputs=all

# rules_xcodeproj needs toplevel to download needed outputs
build:rules_xcodeproj --remote_download_outputs=toplevel

# Build with --config=cache to use BuildBuddy Remote Cache
build:cache --bes_backend=grpcs://remote.buildbuddy.io
build:cache --bes_results_url=https://app.buildbuddy.io/invocation/
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 0 additions & 15 deletions xcodeproj/internal/xcodeproj.template.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -62,21 +62,6 @@ build:rules_xcodeproj --show_result=0

build:rules_xcodeproj_generator --config=rules_xcodeproj

# Work around https://github.com/bazelbuild/bazel/issues/11920
#
# If you see a warning like:
#
# WARNING: option '--remote_download_outputs' was expanded to from both option '--remote_download_minimal' (source $WORKSPACE/.bazelrc) and option '--config=rules_xcodeproj_generator' (source command line options)
#
# Then you should change your use of `--remote_download_minimal` to these
# individual flags:
#
# --nobuild_runfile_links (don't set this one if using `--remote_download_toplevel`)
# --experimental_inmemory_jdeps_files
# --experimental_inmemory_dotd_files
#
run:rules_xcodeproj_generator --remote_download_outputs=all

### `--config=rules_xcodeproj_info`
#
# Used when querying `bazel info`.
Expand Down

0 comments on commit 1f928a9

Please sign in to comment.