[WIP] Store 5: Multiplatform Write Support #443
Conversation
| @@ -18,6 +18,9 @@ buildscript { | |||
| classpath "org.jacoco:org.jacoco.core:${versions.jacocoGradlePlugin}" | |||
| classpath "org.jetbrains.kotlinx:atomicfu-gradle-plugin:${versions.atomicFuPlugin}" | |||
| classpath "com.vanniktech:gradle-maven-publish-plugin:${versions.mavenPublishPlugin}" | |||
| classpath("app.cash.zipline:zipline-gradle-plugin:0.9.1") | |||
| classpath("com.squareup.sqldelight:gradle-plugin:1.5.3") | |||
There was a problem hiding this comment.
move versions to dependencies.gradle
| @@ -18,6 +18,9 @@ buildscript { | |||
| classpath "org.jacoco:org.jacoco.core:${versions.jacocoGradlePlugin}" | |||
| classpath "org.jetbrains.kotlinx:atomicfu-gradle-plugin:${versions.atomicFuPlugin}" | |||
| classpath "com.vanniktech:gradle-maven-publish-plugin:${versions.mavenPublishPlugin}" | |||
| classpath("app.cash.zipline:zipline-gradle-plugin:0.9.1") | |||
| classpath("com.squareup.sqldelight:gradle-plugin:1.5.3") | |||
| classpath("com.google.dagger:hilt-android-gradle-plugin:2.42") | |||
There was a problem hiding this comment.
in this house we use anvil :-D jk, glad you got this into the sample, extract version pls
| @@ -26,7 +29,7 @@ apply from: 'buildsystem/dependencies.gradle' | |||
| apply plugin: 'binary-compatibility-validator' | |||
|
|
|||
| apiValidation { | |||
| ignoredProjects += ["app"] | |||
| ignoredProjects += ["reddit", "store", "samples", "notes", "android", "common", "fig"] | |||
There was a problem hiding this comment.
is this temporary? You can run gradlew apiDump to regen the api check file
| @@ -0,0 +1,7 @@ | |||
| plugins { | |||
| `kotlin-dsl` | |||
There was a problem hiding this comment.
why you don't like groovy?
| const val store = "com.dropbox.mobile.store:store4:4.0.5" | ||
| } | ||
|
|
||
| object Koin { |
| @@ -14,7 +14,7 @@ dependencies { | |||
| implementation libraries.okio | |||
| implementation libraries.coroutinesCore | |||
| implementation libraries.cache | |||
| implementation project(path: ':store') | |||
| implementation project(path: ':store4') | |||
There was a problem hiding this comment.
change back, we keep module as store but artifacts as store5, same for the package
There was a problem hiding this comment.
Hey I don't follow - My understanding was current :store becomes :store4. Then Store 5 becomes new :store. And :filesystem, :store-rx2, and :store-rx3 depend on :store4 rather than :store. What am I missing?
There was a problem hiding this comment.
https://github.com/MobileNativeFoundation/Store/tree/main/store/src/main/java/com/dropbox/android/external/store4 rename this package to store5. Rename the maven artifacts to store5. We don't need to have store4 and store5 in repo at same time. Your change can be a breaking change. The important thing is someone can add the store4 and store5 artifacts at same time. There should be 0 references to store4 once all your changes land.
| import io.ktor.http.HttpStatusCode | ||
| import kotlin.collections.set | ||
|
|
||
| class FakeApi(private val client: HttpClient) : Api<Key, Notebook> { |
There was a problem hiding this comment.
You can move this and the other Fake implementations out of the main source path and into the relevant test path
| } | ||
|
|
||
| override suspend fun post(note: MarketNote): Boolean { | ||
| return try { |
There was a problem hiding this comment.
nit: can make these functions more expressive by removing their brackets and return statements.
|
Discussed offline to split this between 3 diffs
|
|
Thanks @digitalbuddha @theBradfo for early feedback. Will incorporate suggestions above in upcoming diffs |
Closes #247, #50, #36, #35, #25