-
-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SARIF and duplication issues #91
Conversation
can you send the changes against libsast as well? |
@ajinabraham I have raised a pull request for libsast here: https://github.com/ajinabraham/libsast/pull/46/files. |
@ajinabraham this pull request has some changes that shouldn't be merged to main (because I ended up switching to our own fork of libsast), but you can probably cherry pick |
Thanks, I am working on this, will take a look and include the changes appropriately |
@ajinabraham thank you, that is much appreciated! If you have any questions or need any help with these changes - feel free to reply here. |
Can you update the PR to use latest libsast? |
Yep, will do shortly :) |
d5156dd
to
95623b7
Compare
@ajinabraham does this look ok? |
This PR fixes two issues:
#90
and
#15 - while this has been closed as completed - I don't see any changes related to it and the behaviour still seems to be in the main branch. This PR fixes the issue.