Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SARIF and duplication issues #91

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Conversation

ls-valentinas-bakaitis
Copy link
Contributor

This PR fixes two issues:
#90
and
#15 - while this has been closed as completed - I don't see any changes related to it and the behaviour still seems to be in the main branch. This PR fixes the issue.

@ajinabraham
Copy link
Member

can you send the changes against libsast as well?

@ls-valentinas-bakaitis
Copy link
Contributor Author

@ajinabraham I have raised a pull request for libsast here: https://github.com/ajinabraham/libsast/pull/46/files.

@ls-valentinas-bakaitis
Copy link
Contributor Author

@ajinabraham this pull request has some changes that shouldn't be merged to main (because I ended up switching to our own fork of libsast), but you can probably cherry pick 291da9ffe83fcbb78267f2cb739d2ccb80ba7540 and 3d3fca46da11a05f71d57425f38d18e360c263d3 to get the needed changes. Then once Libsast PR is merged, you can update libsast.

@ajinabraham
Copy link
Member

Thanks, I am working on this, will take a look and include the changes appropriately

@ls-valentinas-bakaitis
Copy link
Contributor Author

@ajinabraham thank you, that is much appreciated! If you have any questions or need any help with these changes - feel free to reply here.

@ajinabraham
Copy link
Member

Can you update the PR to use latest libsast?

@valentinas
Copy link

Yep, will do shortly :)

@ls-valentinas-bakaitis
Copy link
Contributor Author

@ajinabraham does this look ok?

ajinabraham added a commit that referenced this pull request Nov 5, 2024
@ajinabraham ajinabraham merged commit 6f88801 into MobSF:main Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants