Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests #96

Merged
merged 4 commits into from
Jan 8, 2018
Merged

Fix tests #96

merged 4 commits into from
Jan 8, 2018

Conversation

BehindTheMath
Copy link
Collaborator

No description provided.

@BehindTheMath
Fix tests
96b2add 
See #63

- Switch from testling to jsdom for browser APIs
- Switch from coverify to nyc for coverage reports
- Clean up related dead code and tooling
@BehindTheMath BehindTheMath requested a review from MoOx January 8, 2018 21:59
MoOx
MoOx approved these changes Jan 8, 2018
View reviewed changes
Copy link
Owner

@MoOx MoOx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@BehindTheMath
Fix lint error
df3bccc
@BehindTheMath
Update Travis to use Node v4
30a70a7 
We need some ES6 features for jsdom
@BehindTheMath
Update Travis to use Node v6 and v8
c9d9506 
Apparently we need even more ES6 features for jsdom.
@BehindTheMath BehindTheMath merged commit a2e6cfc into master Jan 8, 2018
@BehindTheMath
Copy link
Collaborator Author

All tests and builds pass now.

@BehindTheMath BehindTheMath deleted the bugfix/fix-tests branch January 8, 2018 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoOx MoOx MoOx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BehindTheMath @MoOx