Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove keyup event listener for forms #184

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Remove keyup event listener for forms #184

merged 1 commit into from
Nov 21, 2018

Conversation

BehindTheMath
Copy link
Collaborator

Let the browser take care of when to do implicit submission.

Fixes #181.

@BehindTheMath
Remove keyup event listener for forms
e577c53 
Let the browser take care of when to do implicit submission.
robinnorth
robinnorth approved these changes Nov 20, 2018
View reviewed changes
Copy link
Collaborator

@robinnorth robinnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible to me. Apologies for the delay in reviewing!

@BehindTheMath BehindTheMath merged commit fefb63a into master Nov 21, 2018
@BehindTheMath BehindTheMath deleted the fix/form-enter branch November 21, 2018 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robinnorth robinnorth robinnorth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BehindTheMath @robinnorth