Skip to content
This repository has been archived by the owner on Sep 7, 2020. It is now read-only.

Add new stylelint rule #849

Merged
merged 2 commits into from
Nov 8, 2016
Merged

Add new stylelint rule #849

merged 2 commits into from
Nov 8, 2016

Conversation

cedricdelpoux
Copy link
Contributor

css-modules are enabled by the default webpack configuration.

The composes rule is very usefull to compose selectors. I think it could be great to enable it directly as a stylelint rule

@MoOx
Copy link
Owner

MoOx commented Oct 28, 2016

Maybe we can do like for eslint config and create a shareable file? (easier for update for user)

@cedricdelpoux
Copy link
Contributor Author

For me, only the composes rules was missing to start a project with css-modules.
Do you have propositions about some others rules ?

@MoOx
Copy link
Owner

MoOx commented Nov 1, 2016

Nothing more for now.

@cedricdelpoux
Copy link
Contributor Author

Do you want I create a personal repo with shareable file ?

@MoOx
Copy link
Owner

MoOx commented Nov 3, 2016

We will handle this as a real package when splitting phenomic as multi packages with a monorepo. For now you can do something similar to what we do for eslint

@MoOx
Copy link
Owner

MoOx commented Nov 4, 2016

Perfect! Will merge for next release, probably next week.

@MoOx MoOx merged commit 9754e50 into MoOx:master Nov 8, 2016
@kevin940726
Copy link
Contributor

This rule was removed in #876 , so the composes keyword error comes back. Should we fix it now? Perhaps with stylelint-config-css-modules.

@MoOx
Copy link
Owner

MoOx commented Feb 6, 2017

Default config is now pretty empty https://github.com/MoOx/phenomic/blob/master/src/stylelint-config-recommended/index.js. You should probably use your own config.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants