Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lambda native env vars #549

Closed
wants to merge 4 commits into from
Closed

Conversation

geeknam
Copy link
Contributor

@geeknam geeknam commented Dec 18, 2016

Description

Add AWS Lambda native environment variables

Related to: #501

@coveralls
Copy link

coveralls commented Dec 18, 2016

Coverage Status

Coverage increased (+0.02%) to 80.78% when pulling 6136f05 on geeknam:feature/aws_envs into 60cd824 on Miserlou:master.

@Miserlou
Copy link
Owner

This looks good, but it doesn't seem connected the the CLI yet - should I expect that in addition this commit?

@geeknam
Copy link
Contributor Author

geeknam commented Dec 20, 2016

@Miserlou Zappa settings already includes environment_variables in stage_config. I'm getting the config from here: https://github.com/geeknam/Zappa/blob/6136f0548f6b42653f2495e880c7522ca5bd638f/zappa/cli.py#L1436

Not sure if that's what you mean

@coveralls
Copy link

coveralls commented Dec 20, 2016

Coverage Status

Coverage decreased (-0.06%) to 80.707% when pulling 7f073e0 on geeknam:feature/aws_envs into 60cd824 on Miserlou:master.

@Miserlou
Copy link
Owner

Ah, so the problem there is that it's a conflict with the existing environment variables, which should be explicitly separated.

Please move these environment variables to the vendor-prefixed aws_environment_variables and update the documentation accordingly.

@Miserlou
Copy link
Owner

Also, the really interesting thing about AWS env vars is the use of KMS. Does this PR address that?

@jonatasbaldin
Copy link
Contributor

@Miserlou could we close this since its merged?

@jneves
Copy link
Collaborator

jneves commented Oct 1, 2018

Already merged.

@jneves jneves closed this Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants