Correção dos testes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luistak
commented
Oct 10, 2020
Comment on lines
+79
to
+83
| const nameInput = screen.getByLabelText('Nome completo'); | ||
| userEvent.type(nameInput, 'Kleber da silva'); | ||
|
|
||
| const cityInput = screen.getByLabelText('Cidade'); | ||
| userEvent.selectOptions(cityInput, 'campinas'); |
There was a problem hiding this comment.
Além dos wrappers, estavam faltando estes dois campos que eram obrigatórios também
| projectId: jest.fn(12345), | ||
| }), | ||
| auth: jest.fn().mockReturnThis(), | ||
| signInWithCustomToken: jest.fn().mockResolvedValue(), | ||
| }; | ||
|
|
There was a problem hiding this comment.
Creio que estes e outros mocks podem ser melhorados no futuro criando "customRenders", para cada um desses providers como neste exemplo
| jest.mock('firebase/app', () => { | ||
| return { | ||
| firestore: jest.fn(() => ({ |
There was a problem hiding this comment.
Há uma outra lib que resolve isso, mas não é 100% segura então resolvi adicionar somente o necessário para o teste funcionar
| expect(newCandidates.length).toEqual(20); | ||
| act(() => { | ||
| userEvent.click(loadMorebutton); | ||
| jest.runOnlyPendingTimers(); |
There was a problem hiding this comment.
Utilizei para rodar os timers do setTimeout interno do componente
victormiguez
approved these changes
Oct 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
O que
Correção dos testes:
Adição do jsdom como env do jest corrigindo este problema
Verificações