Multi arch Dockerfile and CI #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use rustup from Docker image - Give up on cross compilation (ring issue) - Remove useless duplicate cargo install step - No need to specify target as it is built statically for the docker platform targeted - Shorten binary path output for shorter COPY
This was referenced Jul 7, 2021
- Use Debian based Rust for compilation - Cross compile on build platform - Compile static binaries using musl - Set variables correctly for all Docker supported platforms - Note: ppc64le, s390x and riscv64 do not support the Rust standard lib - Persist target platform variables through files - Define linkers in .cargo/config - Cache dependencies properly for target platform - Scratch stage to test the binary for target platform
MindFlavor
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dockerfile changes
:1-bullseye-slimRust image for cross compilation instead of:1-alpine3.13, because:3.13does not work well on 32 bit systems with an older libseccomp like on Raspberry Pisamd64andarm64so users could build the image on their raspberry pis if they want toppc64le,s390xandriscv64do not support the Rust standard lib so it will fail for these/tmp/.cargo/configcargo installinstruction ⚡/tmpto have a shorterCOPYinstruction for readabilityGithub Actions
Github Actions workflows were changed to build for 386, arm64, armv6 and armv7 on top of amd64.
See #48 for an updated list of things left to do.
@MindFlavor feel free to ask questions/suggestions and approve the PR so we can finally have cross built Docker images 🎉