Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up some pickles interfaces #16450

Merged
merged 9 commits into from
Jan 8, 2025
Merged

Conversation

mrmr1993
Copy link
Member

@mrmr1993 mrmr1993 commented Jan 7, 2025

This PR builds upon #16449, tidying up some pickles interfaces to remove spurious references to Snarky_backendless.Cvar.t.

@mrmr1993 mrmr1993 requested a review from a team as a code owner January 7, 2025 10:00
@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 7, 2025

!ci-build-me

Copy link
Member

@dannywillems dannywillems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly type aliases and some renaming.

@mrmr1993
Copy link
Member Author

mrmr1993 commented Jan 7, 2025

!ci-build-me

Base automatically changed from feature/generalize-constraint to compatible January 8, 2025 09:22
@dannywillems
Copy link
Member

!ci-build-me

@dannywillems
Copy link
Member

Taking care of reformatting scalar_challenge.mli

@dannywillems
Copy link
Member

!ci-build-me

@dannywillems dannywillems merged commit de1f5e0 into compatible Jan 8, 2025
44 checks passed
@dannywillems dannywillems deleted the feature/specalize-cvars branch January 8, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants