Batch account lookups for sparse ledger creation #14527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
!ci-build-me |
|
!ci-nightly-me |
db2a399 to
ae81c53
Compare
7 tasks
|
!ci-build-me |
|
!ci-nightly-me |
georgeee
reviewed
Nov 8, 2023
| Either.first (location, Some account) | ||
| | None -> | ||
| Either.second location ) | ||
| let locations_with_locations_rev, leftover_locations_rev = |
|
!ci-build-me |
187ec15 to
c45bc86
Compare
eb3db50 to
2fbe1c5
Compare
georgeee
approved these changes
Nov 27, 2023
src/lib/mina_ledger/sparse_ledger.ml
Outdated
| let path, acct = Ledger.create_empty_exn ledger key in | ||
| (key :: new_keys, add_path sl path key acct) ) | ||
| ~init:([], of_ledger_root ledger) | ||
| let rec go (new_keys, sl) locations accounts = |
There was a problem hiding this comment.
Could be better structured, but will be amended in a PR up the PR chain
ghost-not-in-the-shell
approved these changes
Nov 27, 2023
4123438 to
b992841
Compare
2fbe1c5 to
daa60aa
Compare
nholland94
approved these changes
Nov 28, 2023
|
!ci-build-me |
b992841 to
f8c7017
Compare
daa60aa to
4271394
Compare
Base automatically changed from
feature/batch-account-location-lookups
to
rampup
December 5, 2023 00:19
…d-merkle-masks-for-staged-ledger
…eature/merkle-mask-preloading
…k-empty-account-preloading
…ure/sparse-ledger-of-subset-no-mutability
…ture/sparse-ledger-wide-merkle-paths
|
nightly pipeline passes https://buildkite.com/o-1-labs-2/mina-end-to-end-nightlies/builds/877#_ |
|
!approved-for-mainnet |
…-lookups Batch merkle_path lookups in Sparse_ledger
Replace tables with maps in merkle masks
…e-merkle-paths Use 'wide merkle paths' to optimize `Sparse_ledger.of_ledger_subset_exn`
…subset-no-mutability Avoid ledger copy and mutation in `Sparse_ledger.of_ledger_subset_exn`
…-account-preloading Allow merkle masks to handle empty accounts directly
…ading Preload accounts into merkle path for staged ledger diff application
…asks-for-staged-ledger Performance improvement: fetch merkle paths from masks instead of disk
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist: