Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github Auto sync ] Handle personal branch update #14033

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

dkijania
Copy link
Member

@dkijania dkijania commented Sep 4, 2023

Explain your changes:

Added new logic to handle change in personal branch. It will now create PR for any conflict in earlier or later branch in the chain. Branch with conflict will receive also comment which is pointing developer to proper fixing conflict PR.

Explain how you tested your changes:

I tested it on my private repository where is duplicated our stable branches + added merges cleanly jobs.

Checklist:

  • Dependency versions are unchanged
    • Notify Velocity team if dependencies must change in CI
  • Modified the current draft of release notes with details on what is completed or incomplete within this project
  • Document code purpose, how to use it
    • Mention expected invariants, implicit constraints
  • Tests were added for the new behavior
    • Document test purpose, significance of failures
    • Test names should reflect their purpose
  • All tests pass (CI will check this if you didn't)
  • Serialized types are in stable-versioned modules
  • Does this close issues? List them
  • Closes #0000

@dkijania dkijania force-pushed the dkijania/branch_auto_sync_forward_branches branch from 2b1393d to 052379a Compare October 16, 2023 16:05
@dkijania
Copy link
Member Author

!ci-build-me

@dkijania
Copy link
Member Author

!ci-build-me

@dkijania dkijania self-assigned this Nov 28, 2023
@dkijania dkijania merged commit 79c11f5 into develop Nov 28, 2023
1 check passed
@dkijania dkijania deleted the dkijania/branch_auto_sync_forward_branches branch November 28, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant