Merge pull request #14566 from MinaProtocol/fix/lookup-tables

Deduplicate lookup tables
MinaProtocol · Nov 16, 2023 · 5ea4bd1 · 5ea4bd1
2 parents 3e99d52 + f60f1f4
commit 5ea4bd1
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/src/lib/crypto/proof-systems b/src/lib/crypto/proof-systems
diff --git a/src/lib/pickles/fix_domains.ml b/src/lib/pickles/fix_domains.ml
@@ -42,14 +42,11 @@ let domains (type field gates) ?feature_flags
             feature_flags
           in
           let combined_lookup_table_length =
-            let range_check_table_used = range_check0 || range_check1 || rot in
-            let range_check_table_used_again =
-              (* FIXME: This is a hack around a bug in proof-systems. *)
-              foreign_field_mul
+            let range_check_table_used =
+              range_check0 || range_check1 || foreign_field_mul || rot
             in
             let xor_table_used = xor in
             (if range_check_table_used then Int.pow 2 12 else 0)
-            + (if range_check_table_used_again then Int.pow 2 12 else 0)
             + (if xor_table_used then Int.pow 2 8 else 0)
             + ( if lookup then (
                 Kimchi_backend_common.Plonk_constraint_system
+13 −2		kimchi/src/circuits/constraints.rs
+47 −0		kimchi/src/circuits/lookup/tables/mod.rs