Skip to content

Commit

Permalink
Remove CLI configuration flags
Browse files Browse the repository at this point in the history
  • Loading branch information
joaosreis committed Nov 27, 2023
1 parent badc614 commit 3a5d45a
Showing 1 changed file with 3 additions and 16 deletions.
19 changes: 3 additions & 16 deletions rfcs/0051-stop-transaction-processing.md
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ blocks after a certain slot will be as follows:

* There will be a configuration parameter set at compile-time that will define
the slot at which the node will stop processing transactions.
* The previous configuration should be overridable at runtime by optional CLI
flags.
* The previous configuration cannot be overridable at runtime, by design, as
this compromises the safety of the daemon software.
* The node (daemon) will stop accepting new transactions from clients after
the configured slot.
* After the configured slot, the block producer will stop including transactions
Expand All @@ -54,8 +54,6 @@ next:

* There will be a configuration parameter set at compile-time that will define
the slot at which the node will stop the network.
* The previous configuration should be overridable at runtime by optional CLI
flags.
* After the configured slot, the block producer will stop producing any blocks.
* The block validator will reject any blocks received after the stop network
* slot.
Expand All @@ -64,7 +62,7 @@ next:

Each of these procedures will be described in detail in the following sections.

### Compile-time configuration and CLI flag
### Compile-time configuration

The configuration parameters `slot_tx_end` and `slot_chain_end` will be set at
compile-time and will define the slot at which the node will stop processing
Expand All @@ -74,17 +72,6 @@ configuration parameters will be optional and will default to `None`. If
If `slot_chain_end` is set to `None`, the node will not stop producing or
validating blocks.

There will be two optional CLI flags that will override this configuration.

* `--slot-tx-end`: if set to `none`, disables the feature by setting the
slot at which the node will stop processing transactions to `None`. If set to
a slot, enables the stop transaction processing feature and sets the value
passed as the slot at which the node will stop processing transactions.
* `--slot-network-end`: if set to `none`, disables the feature by setting the
slot at which the node will stop to `None`. If set to a slot, enables the stop
network feature and sets the value passed as the slot at which the node will
stop producing/validating blocks.

### Client submits transaction

When a client sends a transaction to the node daemon, the node will check if
Expand Down

0 comments on commit 3a5d45a

Please sign in to comment.