Substitute null for unspecified optional inputs in direct SQL execution #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycekbargar
approved these changes
Jun 21, 2019
| // Optional input are not handled explicitly for saved searches -- | ||
| // Per relativity this is not officially supported, so if an optional search input | ||
| // is not supplied the script execution will simply fail. | ||
| // https://devhelp.relativity.com/t/documentation-around-non-required-relativity-script-inputs/6535/5 |
There was a problem hiding this comment.
Is there a way we can hard fail here with a clear error message? Or is that actually worse than failing like Relativity would?
There was a problem hiding this comment.
I'd rather just let it fall through to the error you'd get with the script since the default behavior is "it's just null, even if it's really an unescaped string substituted for a column name" (not sure how that works, but it does), except in the case of saved searches where it just flat out doesn't work anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optional inputs were not handled in direct SQL execution. This will substitute a literal SQL NULL for any input whose value was not saved by ScriptRunner; input values are NULL if an optional input is not entered in scripts, and the standard way to check for presence of an optional input in a Relativity script is to run ISNULL. Note the frontend forces users to enter values for required inputs, this means only optional inputs would not have a value saved.