fix: missingHandlerPolicy not passed to a MockLink when creating a client #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would appreciate your review @Mike-Gibson |
a288bca to
5b47d44
Compare
5b47d44 to
8649563
Compare
|
Hey @mykolavlasov - thanks for fixing. Apologies that I missed this in the original PR! Great that you added an integration test for it 👍 I've published 1.3.1 which includes this fix. |
Thanks a lot for the quick response and for publishing a new version, I greatly appreciate it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added
missingHandlerPolicyfield for the MockLink and as an option for thecreateMockClientin my previous PRHowever, it wasn't passed from to a
MockLinkwhen it was initialized inside of thecreateMockClient.I fixed it in this PR and added an integration test for it