Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue resolution updates #391

Merged
merged 12 commits into from
Aug 24, 2021
Merged

Issue resolution updates #391

merged 12 commits into from
Aug 24, 2021

Conversation

mattwojo
Copy link
Collaborator

No description provided.

Addresses issue #196
*On my Surface Book keyboard + and = are the same key, but this may not be the case for all keyboard layouts.
@opbld30
Copy link

opbld30 commented Aug 23, 2021

Docs Build status updates of commit 4fb927f:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ⚠️Warning View Details
TerminalDocs/new-terminal-arguments.md ⚠️Warning View Details
TerminalDocs/customize-settings/actions.md 💡Suggestion View Details
TerminalDocs/panes.md ✅Succeeded View

TerminalDocs/command-line-arguments.md

  • Line 48, Column 106: [Warning-file-not-found] Invalid file link: './actions.md'.

TerminalDocs/new-terminal-arguments.md

  • Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

TerminalDocs/customize-settings/actions.md

  • Line 1107, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld33
Copy link

opbld33 commented Aug 23, 2021

Docs Build status updates of commit 0c814fd:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ⚠️Warning View Details
TerminalDocs/new-terminal-arguments.md ⚠️Warning View Details
TerminalDocs/customize-settings/actions.md 💡Suggestion View Details
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/panes.md ✅Succeeded View

TerminalDocs/command-line-arguments.md

  • Line 48, Column 106: [Warning-file-not-found] Invalid file link: './actions.md'.

TerminalDocs/new-terminal-arguments.md

  • Line 0, Column 0: [Warning-h1-missing] H1 is required. Use a single hash (#) followed by a space to create your top-level heading.

TerminalDocs/customize-settings/actions.md

  • Line 1107, Column 2: [Suggestion-column-header-missing] Column headers are required for tables. Add appropriate header text, or remove any extra table cells that cause an extra column.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Aug 24, 2021

Docs Build status updates of commit 3258a40:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/custom-terminal-gallery/custom-schemes.md ⚠️Warning View Details
TerminalDocs/customize-settings/actions.md ⚠️Warning View Details
TerminalDocs/customize-settings/appearance.md ⚠️Warning View Details
TerminalDocs/customize-settings/color-schemes.md ⚠️Warning View Details
TerminalDocs/customize-settings/interaction.md ⚠️Warning View Details
TerminalDocs/customize-settings/profile-advanced.md ⚠️Warning View Details
TerminalDocs/customize-settings/profile-appearance.md ⚠️Warning View Details
TerminalDocs/customize-settings/profile-general.md ⚠️Warning View Details
TerminalDocs/customize-settings/rendering.md ⚠️Warning View Details
TerminalDocs/customize-settings/startup.md ⚠️Warning View Details
TerminalDocs/tutorials/powerline-setup.md ⚠️Warning View Details
TerminalDocs/tutorials/ssh.md ⚠️Warning View Details
TerminalDocs/command-palette.md 💡Suggestion View Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View

TerminalDocs/custom-terminal-gallery/custom-schemes.md

  • Line 16, Column 74: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/actions.md

  • Line 14, Column 291: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/appearance.md

  • Line 13, Column 143: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/color-schemes.md

  • Line 13, Column 191: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 42, Column 61: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/interaction.md

  • Line 13, Column 143: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/profile-advanced.md

  • Line 13, Column 198: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/profile-appearance.md

  • Line 13, Column 198: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/profile-general.md

  • Line 13, Column 198: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 70, Column 457: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 93, Column 226: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 70, Column 65: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows/wsl/install-win10' will be broken in isolated environments. Replace with a relative link.

TerminalDocs/customize-settings/rendering.md

  • Line 13, Column 143: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/startup.md

  • Line 13, Column 143: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 35, Column 93: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/tutorials/powerline-setup.md

  • Line 79, Column 297: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/tutorials/ssh.md

  • Line 19, Column 259: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/command-palette.md

  • Line 37, Column 260: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows/uwp/design/style/segoe-ui-symbol-font' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld32
Copy link

opbld32 commented Aug 24, 2021

Docs Build status updates of commit ffa1f52:

⚠️ Validation status: warnings

File Status Preview URL Details
TerminalDocs/customize-settings/color-schemes.md ⚠️Warning View Details
TerminalDocs/customize-settings/profile-general.md ⚠️Warning View Details
TerminalDocs/customize-settings/startup.md ⚠️Warning View Details
TerminalDocs/command-palette.md 💡Suggestion View Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/custom-terminal-gallery/custom-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/rendering.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

TerminalDocs/customize-settings/color-schemes.md

  • Line 42, Column 61: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/customize-settings/profile-general.md

  • Line 70, Column 457: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 93, Column 226: [Warning-file-not-found] Invalid file link: './get-started.md'.
  • Line 70, Column 65: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows/wsl/install-win10' will be broken in isolated environments. Replace with a relative link.

TerminalDocs/customize-settings/startup.md

  • Line 35, Column 93: [Warning-file-not-found] Invalid file link: './get-started.md'.

TerminalDocs/command-palette.md

  • Line 37, Column 260: [Suggestion-docs-link-absolute] Absolute link 'https://docs.microsoft.com/windows/uwp/design/style/segoe-ui-symbol-font' will be broken in isolated environments. Replace with a relative link.

For more details, please refer to the build report.

If you see build warnings/errors with permission issues, it might be due to single sign-on (SSO) enabled on Microsoft's GitHub organizations. Please follow instructions here to re-authorize your GitHub account to Docs Build.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

Note: Your PR may contain errors or warnings unrelated to the files you changed. This happens when external dependencies like GitHub alias, Microsoft alias, cross repo links are updated. Please use these instructions to resolve them.

For any questions, please:

@opbld30
Copy link

opbld30 commented Aug 24, 2021

Docs Build status updates of commit 562da65:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/custom-terminal-gallery/custom-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/color-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/customize-settings/rendering.md ✅Succeeded View
TerminalDocs/customize-settings/startup.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@cinnamon-msft
Copy link
Collaborator

Overall this looks good. I just had some syntax suggestions and I'm not sure the bottom section of the Settings.json blurb on the Get Started page is needed. :)

mattwojo and others added 3 commits August 24, 2021 11:38
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
Co-authored-by: Kayla Cinnamon <cinnamon@microsoft.com>
@opbld33
Copy link

opbld33 commented Aug 24, 2021

Docs Build status updates of commit b8b7b92:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/custom-terminal-gallery/custom-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/color-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/customize-settings/rendering.md ✅Succeeded View
TerminalDocs/customize-settings/startup.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld33
Copy link

opbld33 commented Aug 24, 2021

Docs Build status updates of commit 69ba53b:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/custom-terminal-gallery/custom-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/color-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/customize-settings/rendering.md ✅Succeeded View
TerminalDocs/customize-settings/startup.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@opbld31
Copy link

opbld31 commented Aug 24, 2021

Docs Build status updates of commit eb0947d:

✅ Validation status: passed

File Status Preview URL Details
TerminalDocs/command-line-arguments.md ✅Succeeded View
TerminalDocs/command-palette.md ✅Succeeded View
TerminalDocs/custom-terminal-gallery/custom-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/actions.md ✅Succeeded View
TerminalDocs/customize-settings/appearance.md ✅Succeeded View
TerminalDocs/customize-settings/color-schemes.md ✅Succeeded View
TerminalDocs/customize-settings/interaction.md ✅Succeeded View
TerminalDocs/customize-settings/profile-advanced.md ✅Succeeded View
TerminalDocs/customize-settings/profile-appearance.md ✅Succeeded View
TerminalDocs/customize-settings/profile-general.md ✅Succeeded View
TerminalDocs/customize-settings/rendering.md ✅Succeeded View
TerminalDocs/customize-settings/startup.md ✅Succeeded View
TerminalDocs/dynamic-profiles.md ✅Succeeded View
TerminalDocs/get-started.md ✅Succeeded View
TerminalDocs/new-terminal-arguments.md ✅Succeeded
TerminalDocs/panes.md ✅Succeeded View
TerminalDocs/search.md ✅Succeeded View
TerminalDocs/troubleshooting.md ✅Succeeded View
TerminalDocs/tutorials/powerline-setup.md ✅Succeeded View
TerminalDocs/tutorials/ssh.md ✅Succeeded View

For more details, please refer to the build report.

Note: Broken links written as relative paths are included in the above build report. For broken links written as absolute paths or external URLs, see the broken link report.

For any questions, please:

@mattwojo mattwojo merged commit 55a79ac into live Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants